Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inertia compatibility #68

Closed
Im-Fran opened this issue Mar 1, 2021 · 4 comments
Closed

Inertia compatibility #68

Im-Fran opened this issue Mar 1, 2021 · 4 comments

Comments

@Im-Fran
Copy link
Contributor

Im-Fran commented Mar 1, 2021

I'm using the middleware 'forbid-banned-user', which is working as expected but inertiajs has a little problem with redirects, you must specify the redirect response code 303 which is explained here, it would be useful to have like a setting that enables/disables the inertia fix, like:

// ...
'inertia-fix' => false, // default false, you can change it to true.
// ...

and if it's true you will add 303 as redirect response code. I would do it by myself but I'm a bit busy.

@antonkomarev
Copy link
Member

antonkomarev commented Mar 1, 2021

Thanks for sharing this issue @Im-Fran!
Middleware my be on your side, just copy-paste it to your app, modify and use own implementation

@Im-Fran
Copy link
Contributor Author

Im-Fran commented Mar 1, 2021

I already did, just for future users with the same issue it would be great to see :)

@Im-Fran Im-Fran closed this as completed Mar 1, 2021
This was referenced Mar 1, 2021
@antonkomarev
Copy link
Member

antonkomarev commented Mar 8, 2021

Thank you for the contribution @Im-Fran! Laravel Ban v4.6.0 has been released with Inertia support.
You are in the contributors list now 🎉

@Im-Fran
Copy link
Contributor Author

Im-Fran commented Mar 8, 2021

Awesome! Thanks for the awesome package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants