Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode integration? #213

Open
guettli opened this issue Aug 9, 2024 · 4 comments
Open

vscode integration? #213

guettli opened this issue Aug 9, 2024 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@guettli
Copy link

guettli commented Aug 9, 2024

What version of GCI are you using?

I am using GCI via golangci-lint

❯ golangci-lint --version
golangci-lint has version v1.59.1 built with go1.22.5 from (unknown, modified: ?, mod sum: "h1:CRRLu1JbhK5avLABFJ/OHVSQ0Ie5c4ulsOId1h3TTks=") on (unknown)

What did you expect to see?

If I save the file in vscode, I would like my file to get automatically formatted correctly.

What did you see instead?

I see a warning in vscode (and unfortunately no quick-fix action is available)

@daixiang0 daixiang0 added enhancement New feature or request help wanted Extra attention is needed labels Aug 12, 2024
@daixiang0
Copy link
Owner

It should be done by golangci-lint first then GCI can support it.

@guettli
Copy link
Author

guettli commented Aug 12, 2024

@daixiang0 can you please elaborate? What needs to be done by golangci-lint? Is this something I can configure, or is this an open feature request of golangci-lint?

@daixiang0
Copy link
Owner

daixiang0 commented Aug 13, 2024

There would be a vscode extension about golangci-lint, then as a part of it, GCI would do some implement to support.

Yep, should post a feature request to golangci-lint first.

@guettli
Copy link
Author

guettli commented Aug 13, 2024

I use the documented vscode integration of golangci-lint:

https://golangci-lint.run/welcome/integrations/

"go.lintTool": "golangci-lint",
"go.lintFlags": [
  "--fast"
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants