Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make python test dependencies optional #815

Merged

Conversation

CollectiveUnicorn
Copy link
Contributor

@CollectiveUnicorn CollectiveUnicorn commented Jul 22, 2024

@CollectiveUnicorn CollectiveUnicorn requested a review from a team as a code owner July 22, 2024 18:34
Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for leapfrogai-docs canceled.

Name Link
🔨 Latest commit 426dd32
🔍 Latest deploy log https://app.netlify.com/sites/leapfrogai-docs/deploys/66a6f7546ce4ab000928edd1

@CollectiveUnicorn CollectiveUnicorn changed the base branch from main to port-load-tests July 22, 2024 18:35
gphorvath
gphorvath previously approved these changes Jul 22, 2024
@CollectiveUnicorn
Copy link
Contributor Author

This PR affects and is affected by: #808 - will wait on it to go through before updating this PR

jalling97
jalling97 previously approved these changes Jul 23, 2024
justinthelaw
justinthelaw previously approved these changes Jul 23, 2024
src/leapfrogai_api/Makefile Outdated Show resolved Hide resolved
Co-authored-by: Jonathan Perry <YrrepNoj@gmail.com>
YrrepNoj
YrrepNoj previously approved these changes Jul 24, 2024
@gphorvath
Copy link
Contributor

This PR affects and is affected by: #808 - will wait on it to go through before updating this PR

It looks like #808 is going to need more work, so maybe retarget to main so it can be merged @CollectiveUnicorn?

@CollectiveUnicorn
Copy link
Contributor Author

Right now its targeted at port-load-tests since there's load test related dependencies included and readme changes.

Base automatically changed from port-load-tests to main July 26, 2024 19:49
@CollectiveUnicorn CollectiveUnicorn dismissed stale reviews from YrrepNoj, justinthelaw, jalling97, and gphorvath July 26, 2024 19:49

The base branch was changed.

@CollectiveUnicorn CollectiveUnicorn merged commit 89ff0a6 into main Jul 29, 2024
14 checks passed
@CollectiveUnicorn CollectiveUnicorn deleted the 809-chore-make-python-test-dependencies-optional branch July 29, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Make Python test dependencies optional
5 participants