-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
excellent examples pull in Pepr dist folder to test new api functionality #1109
Comments
I'm not 100% that this would be better than just symlinking pepr --> pepr-excellent-examples/node_modules/pepr as we've been doing manually. 🤔 moduleBuild is called for every excellent example which means that an update as described would do a separate clone & build every time, which... would not be awesome. I suspect it'd be easier / faster to just add the symlinking as a distinct step before we ran the test suite in CI, no? |
A manual workaround for developers is included as part of pepr-excellent-examples. I'll consider both approaches as I work on this |
I think that just formalizing the manual workaround would be for the best, honestly. Trying to change moduleBuild() do that stuff just means we'll be wasting a bunch of time / cycles cloning / building over and over (once for every excellent example run, at least); would introduce the possibility that git can have issues that spill into the test runs (like having config / credential issues); would require a connection to GitHub for the tests to run, and so on. I think its better to just assume / aim for a situation where -- by the time the tests run (anything after |
After some review, the best option seems to be using the approach taken by tests in I ran into some issues with file path references that ate up a lot of time, so a usable solution shouldn't be as brittle as things are right now. For reference:
|
Is your feature request related to a problem? Please describe.
When there are changes to the surface of the Pepr api, excellent examples is not able to be run against them in CI until the branch is pulled into main.
Describe the solution you'd like
moduleBuild
Describe alternatives you've considered
(optional) A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: