Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing VA check for the 1st matching event #186

Merged
merged 1 commit into from
Oct 8, 2019
Merged

fix: missing VA check for the 1st matching event #186

merged 1 commit into from
Oct 8, 2019

Conversation

mmta
Copy link
Contributor

@mmta mmta commented Oct 8, 2019

This is true when the 2nd and subsequent rules never refer to the same IP/port combination in the first rule.

This is true when the 2nd and subsequent rules never refer to the same
IP/port combination in the first rule.
@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #186 into master will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #186     +/-   ##
=========================================
- Coverage   96.14%   96.04%   -0.1%     
=========================================
  Files          39       42      +3     
  Lines        2775     2832     +57     
  Branches        0        5      +5     
=========================================
+ Hits         2668     2720     +52     
  Misses         74       74             
- Partials       33       38      +5
Impacted Files Coverage Δ
internal/pkg/dsiem/siem/backlog.go 91.14% <100%> (-0.06%) ⬇️
internal/pkg/dsiem/alarm/helper.go 100% <100%> (ø) ⬆️
web/ui/src/polyfills.ts 100% <0%> (ø)
web/ui/src/test.ts 100% <0%> (ø)
web/ui/src/app/app.component.ts 80% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ec6455...90d41e6. Read the comment docs.

@mergify mergify bot merged commit 0d25c90 into master Oct 8, 2019
@mergify mergify bot deleted the dev branch October 8, 2019 22:56
@defenbot
Copy link

defenbot commented Oct 8, 2019

🎉 This PR is included in version 0.25.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants