[BUG]: Error handling not good in node.go:nodeProbe() and other similar functions

[donatwork]

Bug Description

In nodeProbe the call to goscaleio.DrvCfgQueryGUID() can fail for a number of reasons. The error check does not log the actual error and not all code paths in DrvCfgQueryGUID() log errors for serviceability. We have had a number of issue that have proven to be tedious to troubleshoot without seeing the errors from the lower layers. Improvements are needed to make the code more serviceable.

Logs

error: time="2024-04-16T17:13:52Z" level=fatal msg="grpc failed" error="rpc error: code = FailedPrecondition desc = unable to get SDC GUID via config or automatically"

Screenshots

No response

Additional Environment Information

No response

Steps to Reproduce

Reach out to me. Will update this once I get more info.

Expected Behavior

Show the actual error so that the issue can be better understood.

CSM Driver(s)

csi-powerflex 2.10. The problem exists in main.

Installation Type

Helm, not really sure. Contact me for details.

Container Storage Modules Enabled

No response

Container Orchestrator

minikube

Operating System

Linux

[csmbot]

@donatwork: Thank you for submitting this issue!

The issue is currently awaiting triage. Please make sure you have given us as much context as possible.

If the maintainers determine this is a relevant issue, they will remove the needs-triage label and respond appropriately.

---

We want your feedback! If you have any questions or suggestions regarding our contributing process/workflow, please reach out to us at container.storage.modules@dell.com.

[adarsh-dell]

Hi @donatwork,

Is the request asking to precisely replicate the error message retrieved from https://github.com/dell/csi-powerflex/blob/7775ff900314e03cdec5a861d7b79dd42f9bc3e8/service/node.go#L472 and update the code at https://github.com/dell/csi-powerflex/blob/7775ff900314e03cdec5a861d7b79dd42f9bc3e8/service/node.go#L475 to:

if err != nil {
    return status.Errorf(codes.FailedPrecondition,
        "unable to get SDC GUID via config or automatically: %s", err)
}

Best regards,
Adarsh

[donatwork]

Yes, the request is to evaluate the code throughout the driver and check for cases where errors lower down are not propagated to the higher layers in order to improve serviceability. I mentioned only one place as I was investigating an issue. There may be many other places where this problem exists.

[adarsh-dell]

Yes, the request is to evaluate the code throughout the driver and check for cases where errors lower down are not propagated to the higher layers in order to improve serviceability. I mentioned only one place as I was investigating an issue. There may be many other places where this problem exists.

Sure, thanks for bringing this to our attention.

[suryagupta4]

/sync