Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database setup in Initial Setup wiki #1011

Closed
dondi opened this issue Jan 11, 2023 · 11 comments
Closed

Database setup in Initial Setup wiki #1011

dondi opened this issue Jan 11, 2023 · 11 comments

Comments

@dondi
Copy link
Owner

dondi commented Jan 11, 2023

We have documented our database setup instructions but they are not linked to from the Initial Setup wiki page. Let’s do that

@dondi
Copy link
Owner Author

dondi commented Jan 11, 2023

@Onariaginosa
Copy link
Collaborator

Database setup instructions are linked from the Initial Setup wiki page.

@Onariaginosa
Copy link
Collaborator

We finally fixed the database issue! It wasn't actually a big in the code, Sequelize was rounding the timestamps from PostgreSQL, causing the timestamp to not work when querying for specific genes. I changed the network generation code to ignore the milliseconds and that did the trick on both @Onariaginosa and @ntran18 's machines. We did a fresh network database install and it worked

@kdahlquist
Copy link
Collaborator

As noted in issue #1014, @ntran18 is still working on documentation on how to load the database. She's going to edit the PDF from the databases class and select only the items necessary for GRNsight and add it to the wiki.

@kdahlquist
Copy link
Collaborator

The timestamps included milliseconds, but we are truncating because we don't need this level of precision.

@ntran18
Copy link
Collaborator

ntran18 commented Mar 8, 2023

I added one line in the database setup page to go back to initial setup page and continue on the instructions. I also deleted some slides on the Postgres instruction setup for GRNsight.
postgresql-setup-day.pdf

@dondi
Copy link
Owner Author

dondi commented Mar 8, 2023

Given the abridged/distilled content of the PDF and some overlapping bullets in the database setup wiki, let’s see if we can skip the need for the separate PDF, so that the user can just read through things

@ahmad00m suggests separating out the commands that are only run once (i.e., for setup) from the commands that one runs every time (placeholder has been included in the https://github.com/dondi/GRNsight/wiki/Initial-Setup wiki)

@ntran18
Copy link
Collaborator

ntran18 commented Mar 29, 2023

I have modified the database setup to remove the PDF and combine overlapping bullets. I also added "Reuse Commands" section at the end of wiki page

@dondi
Copy link
Owner Author

dondi commented Sep 12, 2023

@nchun2 posted some notes on the database documentation in #1046 —please review with her to see if those changes should be made. After resolution, we can close this issue (we will just open a new one if a future documentation glitch is identified)

@dondi
Copy link
Owner Author

dondi commented Sep 26, 2023

Based on the latest findings in #1046 @nchun2 will check our current database documentation to see if there are critical/immediate changes needed; otherwise, we can close this and open future issues for documentation

By critical/immediate change, we can limit to:

  • Existing errors in the documentation
  • Missing steps outside of being distinct in Windows

Additive content (e.g., alternative paths/commands to do when on a different platform) can be a separate issue after #1046 is fully resolved

@dondi
Copy link
Owner Author

dondi commented Oct 10, 2023

Edits have been made to the wiki

@dondi dondi closed this as completed Oct 10, 2023
@ntran18 ntran18 mentioned this issue Sep 25, 2024
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants