Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protein-protein interaction UI refinements #1028

Closed
3 of 4 tasks
kdahlquist opened this issue Mar 22, 2023 · 8 comments
Closed
3 of 4 tasks

protein-protein interaction UI refinements #1028

kdahlquist opened this issue Mar 22, 2023 · 8 comments

Comments

@kdahlquist
Copy link
Collaborator

kdahlquist commented Mar 22, 2023

@kdahlquist has reviewed this and edited this comment.

  • generate network modal should look the same as for the GRN, except change the labels
    • I think this is done
  • export to SIF and Excel, not graphml
    • cell A1 of the exported Excel workbook "network" sheet; does not need to say "Cols regulators, rows targets", instead it should say "Cols protein1, rows protein2"
  • do not color boxes with expression data Upon reflection, this is more nuanced. The default is that there should be no node coloring. However, if the user checks "Enable Node Coloring" either from the side panel or top menu, then it should behave as if it is a GRN. This will be a change from the current behavior on beta 7.0.2
@dondi dondi changed the title protein-protein interaction UI functionality protein-protein interaction UI refinements Sep 5, 2023
@dondi dondi assigned ntran18 and nchun2 and unassigned Onariaginosa Sep 5, 2023
@dondi
Copy link
Owner

dondi commented Sep 5, 2023

These are in the beta branch; also, there are multiple separate issues and based on the magnitude of the issues, one or more may be large enough to become its own issue

  1. Initial assignment is both @nchun2 and @ntran18 in order to pair over learning about each issue and assessing them overall
  2. Third item (node coloring of PPN) may need further consideration; can consult with @kdahlquist
  3. New issues or this issue can then be assigned directly to @ntran18 (or maybe paired)

@ntran18
Copy link
Collaborator

ntran18 commented Sep 18, 2023

Because my schedule was tight last week, I couldn't meet with @nchun2 to do this issue. We plan to meet on Friday this week.

@dondi
Copy link
Owner

dondi commented Sep 19, 2023

Now that @nchun2 also has GRNsight running locally, maybe @ntran18 and @nchun2 can try for this this week.

@dondi
Copy link
Owner

dondi commented Sep 26, 2023

@ntran18 is traveling this week so it may not be feasible for @ntran18 and @nchun2 to do this together for this week; however if @nchun2’s queue reaches this, it will also be OK for her to look into it on her own and report back

@ntran18
Copy link
Collaborator

ntran18 commented Oct 10, 2023

I didn't have time to schedule a meeting with @nchun2 so I checked this by myself.

  1. Not solved: "cell A1 of the exported Excel workbook "network" sheet; does not need to say "Cols regulators, rows targets", instead it should say "Cols protein1, rows protein2""
  • Example from demo 1:
image
  • Notes from the export-constants.js
image
  1. For the third checklist (node coloring). I already see that feature in the version 7.0.2 beta. However, there is different options between the top menu and the side panel.
  • Side panel:
image
  • Top menu:
image

--> Users can still select top data or bottom data from the top menu, not from the side panel.

@dondi
Copy link
Owner

dondi commented Oct 10, 2023

After @ntran18’s triage, we can go ahead and split the issues; one for the Export (which appears to have a straightforward fix) and another for the node coloring coordination (which will need some deeper thinking because protein-to-protein requires additional integration into our existing UI)

This ticket can be closed after the two separate issues have been written up

@dondi
Copy link
Owner

dondi commented Oct 10, 2023

@nchun2 can take on the error message issue after @ntran18 has extracted it; and possibly look at the protein-protein mode issue as well

@ntran18
Copy link
Collaborator

ntran18 commented Oct 12, 2023

Created 2 new tickets for separated issues: #1054 and #1055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants