Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune undisplayed values from API responses #722

Closed
dondi opened this issue Jan 29, 2019 · 5 comments
Closed

Prune undisplayed values from API responses #722

dondi opened this issue Jan 29, 2019 · 5 comments

Comments

@dondi
Copy link
Owner

dondi commented Jan 29, 2019

No description provided.

@kdahlquist
Copy link
Collaborator

I'm giving this a priority 0.5, and @johnllopez616 should tackle this after dealing with #698, #718, and #723, in that order.

In the API audit and description on the wiki here: https://github.com/dondi/GRNsight/wiki/Web-API-Guide

We saw that there are some data being retrieved that are not displayed on the gene page. So, we want to prune these from the API responses. There are two levels:

  1. Don't ask for it if we don't need it.
  2. If the API request just sends a bunch of stuff without asking, we don't need to store the unused values.

Things that need to be pruned:
From NCBI:

  • alternative name
  • genomic sequence

From Yeastmine:

  • standard name
  • systematic name

We are changing Ensembl to a URL, so that API call becomes irrelevant: #718.

@jlopez616
Copy link
Collaborator

Implemented these changes during work session on 2/18/19. Changes will be available in next PR

@kdahlquist
Copy link
Collaborator

State which PR this is in, please.

@jlopez616
Copy link
Collaborator

Should be fixed following PR #731 , can @dondi confirm?

@dondi
Copy link
Owner Author

dondi commented Feb 26, 2019

Yes, this was noted on code review but I forgot to update the comment.

@dondi dondi closed this as completed Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants