Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor node coloring to fit new MVC paradigm #735

Closed
kdahlquist opened this issue Feb 19, 2019 · 2 comments
Closed

Refactor node coloring to fit new MVC paradigm #735

kdahlquist opened this issue Feb 19, 2019 · 2 comments
Assignees
@mihirsamdarshi
Labels
functionality priority 0 refactor

Comments

@kdahlquist
Copy link
Collaborator

No description provided.

@dondi
Copy link
Owner

dondi commented Mar 26, 2019

To address the data set dropdown question, the notion of "Same as Top Dataset" can be isolated to the view level. Let grnState store the dataset names directly, but upon updating the views, if top and bottom are the same, the dropdown can show "Same as Top Dataset".

@kdahlquist
Copy link
Collaborator Author

@mihirsamdarshi, this is done, right? If so, please close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mihirsamdarshi mihirsamdarshi

Labels
functionality priority 0 refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dondi @mihirsamdarshi @kdahlquist