-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarifying Export-to-Excel interface #978
Comments
I would also generalize the second modal so that the use can select whether or not to export any of the worksheets:
Note that for non-Dahlquist data, they are all wt for now, so for Barreto, for example, it would just be the one sheet "wt_log2_expression" Note also, the "network_weights" sheet is in addition to the "network" sheet. It is a duplicate with the same name, but is necessary for GRNmap to work. |
Also, regarding the placement of the buttons. Should the Continue button go down and to the left of the Close button? Also, maybe the Close button should be labeled Cancel |
For the second modal, move the Export button to the left of the "Close" button, but rename "Close" to "Cancel". Also, since there are two modal windows in a series, should there be a "back" button to take you back to the previous one? |
I started making headway on this refactor / clarification
|
So far so good. Let me know when beta is refreshed and I can look at it. What does "All expression sheets" mean? |
Some notes:
|
One more note: Anything that says "optimized" in the sheet name, came from a GRNmap output file, either from a demo or uploaded to GRNsight. Possibilities include:
Then there are the "sigmas" as in "wt_sigma", etc. These would only come from a demo or an uploaded GRNmap output workbook. We should account for all of these so that we have a complete circular upload/export of identical data. |
@Onariaginosa, let me know if you have questions! |
So, I have began working on fixing the export functionality for this feature. The UI is essentially complete, but the back end exporting functionality doesn't work as it should yet. Coincidentally, I ended up fixing the bug where a network with no regulatory connections crashes GRNsight because it was messing up the export process. Because I couldn't find an open issue it is now referenced as issue #990. As the export to excel functionality is currently wonky, I cannot submit a pr quite yet. |
So export functionality generally works with the new interface. Now I need to focus on generating production rate, degradation rate, and optimization parameter files from our database for export purposes. The export functionality changes are located in WIP PR #985 |
This looks done; some bug testing could be done as part of issue #1012 |
I'd like to clarify the language of the Export-to-Excel modal.
The top part should say:
Select the edge type
Instead of not showing weighted when it's not possible, let's show it, but have it grayed out.
For the bottom part:
The current data should be the top selection, but for the rest, could they be in alphabetical order like they appear in the expression data drop-down menu?
In my mind, if I select expression data from the drop-down in the node menu, that is the option that should be selected when I chose export data to excel. For example, if I load demo #1, change the data to Barreto and then click export, Barreto data should be the one selected, not demo 1.
The text was updated successfully, but these errors were encountered: