Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error with extended query protocol #118

Open
hlinnaka opened this issue Aug 14, 2024 · 2 comments · May be fixed by #147
Open

Error with extended query protocol #118

hlinnaka opened this issue Aug 14, 2024 · 2 comments · May be fixed by #147
Labels
bug Something isn't working
Milestone
0.1.0

Comments

@hlinnaka
Copy link
Collaborator 

postgres=# create table tbl(i int4);
CREATE TABLE
postgres=# select * from tbl  \bind \g
ERROR:  unrecognized node type: 1189775888

See

pg_duckdb/src/pgduckdb_planner.cpp

Line 91 in 177b12b

duckdb_node->custom_private = list_make2(duckdb_connection.release(), prepared_query.release());

The problem is that the type stored in custom_private is supposed to be a copyable Node type, which the duckdb connection and prepared query types are not.
@JelteF JelteF added the bug Something isn't working label Aug 19, 2024
@JelteF JelteF added this to the 0.1.0 milestone Aug 19, 2024
@JelteF
Copy link
Collaborator

JelteF commented Aug 19, 2024

Basically all clients use the extended query protocol. So we should definitely fix this.

@mkaruza
Copy link
Collaborator

mkaruza commented Aug 19, 2024

Agree with @JelteF this should be fixed asap. Simplest, most straight forward solution would be to fix this once we would have one duckdb singleton wrapper object per process - than we would not need to pass this objects around for each query.

@JelteF JelteF linked a pull request Aug 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

Support extended protocol and prepared statements duckdb/pg_duckdb
3 participants
@hlinnaka @JelteF @mkaruza