Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report number of hits, not just pages, for scroll queries #222

Closed
cdahlqvist opened this issue Feb 9, 2017 · 1 comment
Closed

Report number of hits, not just pages, for scroll queries #222

cdahlqvist opened this issue Feb 9, 2017 · 1 comment
Labels
enhancement Improves the status quo :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc.
Milestone
0.6.0

Comments

@cdahlqvist
Copy link
Contributor

It is useful to know how many hits that were retrieved by a scroll query, not just the number of pages, as this allows analysis of the efficiency of various page sizes more easily.
@danielmitterdorfer
Copy link
Member

This can be solved pretty easily and is completely local to Query#scroll_query(). We just need to keep track of the results count and return a dict with the meta-data instead of a tuple.

@danielmitterdorfer danielmitterdorfer added :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc. enhancement Improves the status quo help wanted We'd be happy about a community contribution labels Feb 10, 2017
@danielmitterdorfer danielmitterdorfer added this to the Backlog milestone Feb 10, 2017
@danielmitterdorfer danielmitterdorfer removed the help wanted We'd be happy about a community contribution label May 11, 2017
@danielmitterdorfer danielmitterdorfer modified the milestones: 0.5.4, Backlog May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improves the status quo :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc.
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
2 participants
@danielmitterdorfer @cdahlqvist