Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare Rally for Java 9 #259

Closed
6 tasks done
danielmitterdorfer opened this issue Apr 5, 2017 · 2 comments
Closed
6 tasks done

Prepare Rally for Java 9 #259

danielmitterdorfer opened this issue Apr 5, 2017 · 2 comments
Labels
:Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch :Config Config file format changes, new properties, ... enhancement Improves the status quo meta A high-level issue of a larger topic which requires more fine-grained issues / PRs :Telemetry Telemetry Devices that gather additional metrics
Milestone
0.7.3

Comments

@danielmitterdorfer
Copy link
Member

danielmitterdorfer commented Apr 5, 2017 •
edited
Loading

Java 9 is scheduled for release later this year (see schedule). A few command line flags and other options have changed and we should prepare Rally to be able to adapt.

  • Change configuration routine to auto-detect the highest (stable) Java version (currently checks only for Java 8 and also asks the user about Java 8 explicitly): Rally has the necessary code in place but we will not release it before Java 9 GA as there are additional restrictions in Elasticearch (e.g. ES master has a bootstrap check to avoid that users start with an early access version of Java 9). In short there is too much potential that users shoot themselves into the foot. If somebody still wants to run on JDK 9 before GA, there is still the possibility to edit Rally's configuration file manually. (see Have Rally detect and use more Java versions #265)
  • Check if it is possible to build Elasticsearch with Java 9: At the moment building Elasticsearch against JDK 9 is possible but a bit involved (Gradle needs to run on JDK 8) and I do not plan to support this scenario.
  • Verify that it is possible to run benchmarks with Elasticsearch on Java 9: Positively verified with esrally --distribution-version=5.3.0
  • Make the gc telemetry device work with Java 9 (JVM flags have changed and this fails currently). See Make the gc telemetry device Java 9 compatible #266
  • Verify that the jit telemetry device works with Java 9.
  • Make the jfr telemetry device work with Java 9. See Adjust JVM options for jfr telemetry device on Java 9 #324
@danielmitterdorfer danielmitterdorfer added :Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch :Config Config file format changes, new properties, ... :Telemetry Telemetry Devices that gather additional metrics enhancement Improves the status quo labels Apr 5, 2017
@danielmitterdorfer danielmitterdorfer added this to the 0.5.x milestone Apr 5, 2017
@danielmitterdorfer danielmitterdorfer added the meta A high-level issue of a larger topic which requires more fine-grained issues / PRs label Apr 13, 2017
@danielmitterdorfer danielmitterdorfer removed this from the 0.5.x milestone Apr 13, 2017
@danielmitterdorfer danielmitterdorfer added this to the 0.7.2 milestone Sep 13, 2017
@danielmitterdorfer
Copy link
Member Author

danielmitterdorfer commented Sep 13, 2017 •
edited
Loading

We will not (test and) support Elasticsearch 1.x on Java 9 as initial testing has shown that it fails out of the box with java.lang.UnsupportedOperationException: Boot class path mechanism is not supported on startup. It may be possible to make it work (I did not check) but we will not put any effort into fixing Rally for a version of Elasticsearch that went EOL almost a year ago.

Note that it is still possible to run Rally with Elasticsearch 1.x and Java 8. You just need to manually set java.home in ~/.rally/rally.ini to a valid JDK 8 installation (java.home will replace the current property java8.home once #265 is merged).

@danielmitterdorfer danielmitterdorfer modified the milestones: 0.7.2, 0.7.x, 0.7.3 Sep 18, 2017
@danielmitterdorfer
Copy link
Member Author

Closing as all subtasks are now resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch :Config Config file format changes, new properties, ... enhancement Improves the status quo meta A high-level issue of a larger topic which requires more fine-grained issues / PRs :Telemetry Telemetry Devices that gather additional metrics
Projects
None yet
Milestone
0.7.3
Development

No branches or pull requests
1 participant
@danielmitterdorfer