Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bma/text styles and colors #3459

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jun 3, 2021

Changes

  • use colors defined in https://www.figma.com/file/X4XTH9iS2KGJ2wFKDqkyed/Compound?node-id=557%3A0
  • remove unused resources and code (ex: PercentView)
  • split some resource files into smaller file
  • rework the theme files
  • ensure material theme is used everywhere in the theme and in the layout
  • add default style for some views in the theme (ex: Toolbar, etc.)
  • add some debug screen in the debug menu, to test the themes and the button style
  • rework the button style to use materialThemeOverlay attribute
  • custom tint icon for menu management has been removed
  • comment with riotx has been updated

Main change for developers

Remaining work

  • Cleanup some vector drawables and ensure a tint is always used instead of hard coded color.

@bmarty bmarty force-pushed the feature/bma/text_styles_and_colors branch 4 times, most recently from 5c9316e to 7254af4 Compare June 9, 2021 11:53
@bmarty bmarty marked this pull request as ready for review June 9, 2021 12:21
@bmarty bmarty force-pushed the feature/bma/text_styles_and_colors branch from 7254af4 to dcd2f1d Compare June 9, 2021 12:22
@bmarty bmarty force-pushed the feature/bma/text_styles_and_colors branch from dcd2f1d to 047c59e Compare June 9, 2021 13:36
@bmarty bmarty merged commit 0f4e546 into develop Jun 9, 2021
@bmarty bmarty deleted the feature/bma/text_styles_and_colors branch June 9, 2021 13:36
@bmarty bmarty mentioned this pull request Jun 10, 2021
@bmarty bmarty mentioned this pull request Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant