Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening setting from rageshake dialog crash if there is no session #4445

Closed
bmarty opened this issue Nov 10, 2021 · 0 comments · Fixed by #5649
Closed

Opening setting from rageshake dialog crash if there is no session #4445

bmarty opened this issue Nov 10, 2021 · 0 comments · Fixed by #5649
Assignees
@Florian14
Labels
A-Rageshake O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Crash

Comments

@bmarty
Copy link
Member

bmarty commented Nov 10, 2021

  • Start the app (no session)
  • Shake the device
  • Click on "settings" button in the rageshake dialog -> The app crash.

We should either:

  • hide the "settings" button from the dialog if there is no session (quick fix, but not the best fix)
  • let the rageshake setting being openable even if there is no session (maybe with less options visible?). This is better because on some device rageshake can be triggered even if there is no movement, so user has to be able to disable the feature.
@bmarty bmarty added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Crash A-Rageshake S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Nov 10, 2021
@giomfo giomfo mentioned this issue Mar 28, 2022
Closed
@Florian14 Florian14 mentioned this issue Mar 28, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Florian14 Florian14

Labels
A-Rageshake O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Crash
Projects
None yet
Milestone
No milestone
2 participants
@bmarty @Florian14