Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requestModelBuild() from epoxy Controllers init block #4591

Closed
ariskotsomitopoulos opened this issue Nov 30, 2021 · 0 comments · Fixed by #4592
Closed

Remove requestModelBuild() from epoxy Controllers init block #4591

ariskotsomitopoulos opened this issue Nov 30, 2021 · 0 comments · Fixed by #4592
Assignees
Labels
A-Developer-Experience T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@ariskotsomitopoulos
Copy link
Contributor

Steps to reproduce

According to Epoxy documentation, requestModelBuild() should be called from the main thread:

Note: The first time an EpoxyController builds models it will always run on the main thread, even if you have specified an async handler. This is necessary to allow views to synchronously restore saved state when first created. See Javadoc on EpoxyController#requestModelBuild for more details.

Invoking requestModelBuild() from within epoxy Controller init{} block prevents buildModels() to run in UI thread for the first time.

Outcome

Remove requestModelBuild() from epoxy Controllers init{} block

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Developer-Experience T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant