Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused module matrix-sdk-android-rx and do some cleanup #4942

Merged
merged 5 commits into from
Jan 17, 2022
Merged

Remove unused module matrix-sdk-android-rx and do some cleanup #4942

merged 5 commits into from
Jan 17, 2022

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jan 13, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 13, 2022 •
edited
Loading

Unit Test Results

  66 files  ±0    66 suites  ±0   51s ⏱️ ±0s
135 tests ±0  135 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
418 runs  ±0  418 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 006b212. ± Comparison against base commit a208b48.

♻️ This comment has been updated with latest results.

ouchadam
ouchadam reviewed Jan 13, 2022
View reviewed changes
settings.gradle
@@ -1,6 +1,5 @@
include ':vector'
include ':matrix-sdk-android'
include ':matrix-sdk-android-rx'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

@bmarty
Copy link
Member Author

bmarty commented Jan 13, 2022

Looks like rx is still used in the project attachment-viewer.

@github-actions
Copy link

github-actions bot commented Jan 13, 2022 •
edited
Loading

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    passed="21" failures="0" errors="0" skipped="2"
  • [org.matrix.android.sdk.account]
    passed="1" failures="1" errors="0" skipped="0"
  • [org.matrix.android.sdk.internal]
    passed="158" failures="15" errors="0" skipped="38"
  • [org.matrix.android.sdk.ordering]
    passed="1" failures="1" errors="0" skipped="0"
  • [org.matrix.android.sdk.PermalinkParserTest]
    passed="1" failures="1" errors="0" skipped="0"

@bmarty bmarty merged commit ab29a15 into develop Jan 17, 2022
@bmarty bmarty deleted the feature/bma/delete_rx branch January 17, 2022 10:59
@bmarty bmarty mentioned this pull request Jan 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ouchadam ouchadam ouchadam approved these changes

@ariskotsomitopoulos ariskotsomitopoulos ariskotsomitopoulos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmarty @ouchadam @ariskotsomitopoulos