-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rooms list] Do not suggest collapse the unique section #5347
Comments
We can prepare a PR if you agree with the suggestion |
Hi @giomfo Please raise the PR. If there is only one section, then that section should not be collapsible. We recently made this same decision and change on iOS too. Thanks |
I do not like the idea behind this issue TBH. It should still be collapsible, just for the fact that user can quickly see what's below (= nothing) without having to scroll to the bottom. |
Also the PR #5580 had issues, so reverted for now. |
@bmarty The fact that the section is not collapsible should provide this information (-> no more section below)
@ganfra can you please tell more about the issues? Eventually in the PR #5580 itself |
OK, so, we will have to ensure that this is working:
-> make sure that the "rooms" section is expanded, or expandable again |
(this is not the issue we have seen though) The issues was:
All the fixes are in #5616 from @Florian14 , but we decided to revert the original PR also to discuss a bit more about this "feature" |
I don't think so this case was handled before but it should be fine with #5616: a section is expanded according to a flag value or if there is no other section |
There is also another pb (which is maybe not new)
-> The section is expanded, but the state is not updated, it means that the user has to click twice on the section header to collapse it. |
@Florian14 can we close this issue? |
Your use case
What would you like to do?
In the rooms list, the sections are collapsable
This is ok when there are severals section, but irrelevant when there is only one section.
I suggest here disabling and hiding the option when there is only one section (this is the case for example when I don't have pending invites and when I didn't taf room (favorite/low priority))
When we select a space the case where there is only one section is more frequent
Have you considered any alternatives?
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: