Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If you reply to a redaction, the redacted text still appears #5546

Open
giomfo opened this issue Mar 15, 2022 · 10 comments · Fixed by #6404
Open

If you reply to a redaction, the redacted text still appears #5546

giomfo opened this issue Mar 15, 2022 · 10 comments · Fixed by #6404
Labels
A-Replies O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist Sponsored T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Blocked

Comments

@giomfo
Copy link
Member

giomfo commented Mar 15, 2022

Steps to reproduce

  • Steps to reproduce
  • Send a message
  • Reply to that message
  • Redact the original message
  • The redacted text is displayed, presumably because it's contained in the reply as fallback text

Note:

Outcome

Element-android would not display this text, even though the client has access to it.

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No

@giomfo giomfo added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Mar 15, 2022
@ericdecanini ericdecanini added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-Replies labels Mar 15, 2022
@hafiz013
Copy link

It is same happen to android as well. What i do listen back and pick up all list event redact and remove and link event redact

@giomfo
Copy link
Member Author

giomfo commented Mar 30, 2022

I think this is an issue server side see

  • After checking this is not server side, but client side

@giomfo
Copy link
Member Author

giomfo commented Apr 15, 2022

@daniellekirkwood : please see my suggestion here

@giomfo
Copy link
Member Author

giomfo commented Apr 28, 2022

the plan is described here

@giomfo giomfo self-assigned this Apr 28, 2022
@giomfo giomfo assigned Claire1817 and unassigned giomfo May 25, 2022
@giomfo
Copy link
Member Author

giomfo commented May 25, 2022

blocked, see element-hq/element-ios#5823 (comment)

@jokeyrhyme
Copy link

I just wanted to double-check, is this issue considered to be resolved now per the above PRs and plan?

I just experienced redacted hate spam being preserved and displayed in replies in https://matrix.to/#/!GtIfdsfQtQIgbQSxwJ:archlinux.org?via=matrix.org&via=envs.net&via=tchncs.de when viewed with version 1.6.8 of the Android Element app

I have direct links and a captured video, but it's also disturbing hate speech so I can share that separately

@giomfo
Copy link
Member Author

giomfo commented Jan 5, 2024

@jokeyrhyme Hi, I confirm this issue was considered resolved. It should be closed since version 1.5.20

The fix is a workaround which may have some troubles to fix all the use cases. Is the redacted content still displayed when you force a room timeline refresh (by rotating the screen for example)?

@jokeyrhyme
Copy link

Interesting, so, the conversation in that channel has moved on quite a bit since then, so I've had to scroll back and wait for old message to load again, and I've had to do that multiple times

Anyhow, the redacted content contained within the old replies does indeed still load when scrolling and loading old message history

And rotating the screen does blank out the chat widget and briefly display a loading indicator, but then it all comes back, included the redacted content contained within the old replies

I'm not sure which implemention/version of the server is running for #archlinux:archlinux.org or if that is even involved

And I'm running Element 1.6.8 on Android 14 on a Pixel 6 Pro

@giomfo
Copy link
Member Author

giomfo commented Jan 5, 2024

@jokeyrhyme I did some additional tests on my side with v1.6.8. I was not able to reproduce your issue until I decided to reply to and redact an old message. By old message, I mean a message found by scrolling back far in the room history.
This reminded me a limitation of the workaround. The fix is able to correctly handle a redacted/edited content when the original event is available locally (we decided to not trigger a server request in order to handle synchronously the rendering of the reply_to event). The plan was to fix the most common use cases, where the event we replied to is close in the room history. This may explain the issue you observed.
We will not investigate more this issue - We are currently focusing our effort on a new version of the Element client: https://github.com/element-hq/element-x-android

@jokeyrhyme
Copy link

Thanks for taking a look, and I'm very excited about Element X :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Replies O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist Sponsored T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Blocked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants