Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert :vector to library and introduce new a application module #6407

Closed
ouchadam opened this issue Jun 28, 2022 · 1 comment
Closed

Convert :vector to library and introduce new a application module #6407

ouchadam opened this issue Jun 28, 2022 · 1 comment
Assignees
Labels
A-DevX Anything that can improve the DevX T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-ElementX Z-Modularization

Comments

@ouchadam
Copy link
Contributor

By converting :vector to a library we'll be able to quickly introduce new modules by depending on :vector

We'll introduce a new :vector-app module, name TBC, to be our android application module containing signing configuration, dagger entry point and VectorApplication class

TBD if we want to lift the variants and build types out of the library and only expose them as part of the application module (this has the benefit of making the :vector module cacheable and reusable across variants, speeding up CI build times)

@ouchadam ouchadam added T-Task Refactoring, enabling or disabling functionality, other engineering tasks A-DevX Anything that can improve the DevX Z-Modularization labels Jun 28, 2022
@ouchadam ouchadam self-assigned this Jul 26, 2022
@ouchadam
Copy link
Contributor Author

ouchadam commented Sep 1, 2022

Fixed by #6720 in 1.4.36

@ouchadam ouchadam closed this as completed Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-DevX Anything that can improve the DevX T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-ElementX Z-Modularization
Projects
None yet
Development

No branches or pull requests

2 participants