Check user power level before sharing live location (PSG-620) #6587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurays
changed the title
bmarty
reviewed
Jul 18, 2022
| .setTitle(R.string.live_location_not_enough_permission_dialog_title) | ||
| .setMessage(R.string.live_location_not_enough_permission_dialog_description) | ||
| .setPositiveButton(R.string.ok) { dialogInterface, _ -> | ||
| dialogInterface.dismiss() |
There was a problem hiding this comment.
I do not think this code is necessary. You can replace by
.setPositiveButton(R.string.ok, null)| checkPowerLevelsForLiveLocationSharing() | ||
| } | ||
|
|
||
| private fun checkPowerLevelsForLiveLocationSharing() { |
There was a problem hiding this comment.
Could be rename to observePowerLevelsForLiveLocationSharing since this is using a Flow.
| .map { beaconInfoType -> | ||
| powerLevelsHelper.isUserAllowedToSend(session.myUserId, true, beaconInfoType) | ||
| } | ||
| .all { isUserAllowed -> isUserAllowed } |
There was a problem hiding this comment.
This seems a bit strange to map twice. You can reduce to:
val canShareLiveLocation = EventType.STATE_ROOM_BEACON_INFO
.all { beaconInfoType ->
powerLevelsHelper.isUserAllowedToSend(session.myUserId, true, beaconInfoType)
}There was a problem hiding this comment.
Silly mistake :) Fixed.
| .all { isUserAllowed -> isUserAllowed } | ||
|
|
||
| setState { copy(canShareLiveLocation = canShareLiveLocation) } | ||
| }.launchIn(viewModelScope) |
There was a problem hiding this comment.
Nit: You could use setOnEach for shorter code:
PowerLevelsFlowFactory(room).createFlow()
.distinctUntilChanged()
.setOnEach {
val powerLevelsHelper = PowerLevelsHelper(it)
val canShareLiveLocation = EventType.STATE_ROOM_BEACON_INFO
.all { beaconInfoType ->
powerLevelsHelper.isUserAllowedToSend(session.myUserId, true, beaconInfoType)
}
copy(canShareLiveLocation = canShareLiveLocation)
}There was a problem hiding this comment.
I didn't know that. Perfect, done.
| @@ -3054,6 +3054,8 @@ | |||
| <!-- TODO remove key --> | |||
| <string name="live_location_bottom_sheet_stop_sharing" tools:ignore="UnusedResources">Stop sharing</string> | |||
| <string name="live_location_bottom_sheet_last_updated_at">Updated %1$s ago</string> | |||
| <string name="live_location_not_enough_permission_dialog_title">You don’t have permission to share locations</string> | |||
| <string name="live_location_not_enough_permission_dialog_description">You need to have the right permissions in order to share locations in this room.</string> | |||
There was a problem hiding this comment.
Do those two wording mention live location instead of location? I think this is always possible to share (static) location, so this may be confusing for the user.
bmarty
approved these changes
Jul 19, 2022
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Wha a user tries to share their live location we need to check if the user has enough power level before showing duration bottom sheet or labs flag promotion bottom sheet.
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist