Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using original_event field #7282

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 4, 2022

Homeservers will not return RelationsResponse.original_event in the future.

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

See #7275: stop using original_event field.
We will move to v1 endpoint later (and probably more globally).

Motivation and context

Comply with spec.

Screenshots / GIFs

Tests

  • Smoke tests

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested review from a team and ericdecanini and removed request for a team October 4, 2022 07:55
.findFirst()
} != null
if (!isRootThreadTimelineEventEntityKnown) {
// Fetch the root event from the server
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(we have to do that outside of the Realm transaction below)

@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@bmarty bmarty merged commit 997341b into develop Oct 17, 2022
@bmarty bmarty deleted the feature/bma/remove_original_event branch October 17, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants