-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rich text editor EditText not resizing properly in full screen #7491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok, only minor comments, not blocking
views.richTextComposerEditText.maxLines = 12 | ||
views.plainTextComposerEditText.maxLines = 12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it would make sense having this magic number in a const
views.richTextComposerEditText.maxLines = Int.MAX_VALUE | ||
views.plainTextComposerEditText.maxLines = Int.MAX_VALUE | ||
// This is a workaround to fix incorrect scroll position when maximised | ||
post { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like this kind of workaround because it can introduce crashes or weird glitches but I know it can be difficult to find a better solution... let's see
SonarCloud Quality Gate failed. |
…7491) * Fix rich text editor full screen mode * Add changelog * Address review comments.
Type of change
Content
Changed the EditTexts
maxLines
properties so they are unlimited in full screen mode and go back to 12 when collapsed. Also, improved the way the border for the EditTexts get updated.Motivation and context
When on full screen, the rich text editor EditText height did not match its container because it had the
maxLines = 12
constraint.Screenshots / GIFs
Tests
Tested devices
Checklist