Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice Broadcast - Add max length for recording #7588

Merged
merged 4 commits into from
Nov 15, 2022

Conversation

Florian14
Copy link
Contributor

@Florian14 Florian14 commented Nov 15, 2022

Type of change

  • WIP Feature
  • Bugfix
  • Technical
  • Other :

Content

Add max time for voice broadcast recording and display the remaining time in the timeline tile.
Voice broadcast is automatically stopped when the max time is reached.

Motivation and context

Continue #7127

Screenshots / GIFs

voice_broadcast_remaining_time.mp4

Note: The video has been accelerated

image

Tests

  • Start recording a new voice broadcast
  • Observe that the remaining time is correctly updated
  • Observe that the recording is automatically stopped when at the end of the remaining time

Note: you can change the max length in VoiceBroadcastConstants.MAX_VOICE_BROADCAST_LENGTH_IN_SECONDS for tests purpose

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@Florian14 Florian14 requested review from a team and jmartinesp and removed request for a team November 15, 2022 09:44
@sonarcloud
Copy link

sonarcloud bot commented Nov 15, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

12.4% 12.4% Coverage
0.0% 0.0% Duplication

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from feature/fre/voice_message_persist_playback_state to develop November 15, 2022 16:25
@Florian14 Florian14 merged commit 54fcdcd into develop Nov 15, 2022
@Florian14 Florian14 deleted the feature/fre/voice_broadcast_recording_time branch November 15, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants