sync filter params moved to matrix config

[fedrunov]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

currently sync filter params are stored in session realm which can be cleared. This leads to incorrect filter being used (e.g. without lazyLoadEvents param).

We need to move params to somewhere else, so they won't be cleared

Motivation and context

Screenshots / GIFs

Tests

• Step 1
• Step 2
• Step ...

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[ElementBot]

	Fails
🚫	node failed.

Log

Error:  Error: Could not find the Dangerfile at ./tools/danger/dangerfile-lint.js - does a file exist at danger/dangerfile-lint.js in ./tools?.
    at /usr/src/danger/distribution/platforms/GitHub.js:166:27
    at step (/usr/src/danger/distribution/platforms/GitHub.js:44:23)
    at Object.next (/usr/src/danger/distribution/platforms/GitHub.js:25:53)
    at fulfilled (/usr/src/danger/distribution/platforms/GitHub.js:16:58)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
danger-results://tmp/danger-results-1a64d801.json

Generated by 🚫 dangerJS against bfa2844

[bmarty]

Do we need a database migration because of this change?

[fedrunov]

I've tested upgrading develop build with this branch and there were no problems

[BillCarsonFr]

I added the migration to cleanup the database from the entity added in 45

[bmarty]

LGTM, thanks, just a question about the database migration.
Also did you test to clear cache and see what was the sync filter applied to the sync request?

[fedrunov]

Also did you test to clear cache and see what was the sync filter applied to the sync request?

Yes, I've tested enabling and disabling threads which clears session realm and also tested login with different account. All works fine

[BillCarsonFr]

After a clear cache homeServerCapabilities will be null. That means that the initial sync will have a filter without useThreadNotifications. Is this expected?

Edit
Looks like it's detected and it stores the new filter. Not to familiar with that part of the code but seems to work

[ElementBot]

	Warnings
⚠️	Please add a reviewer to your PR.

Generated by 🚫 dangerJS against 5583172

[ElementBot]

	Warnings
⚠️	Please add a reviewer to your PR.

Generated by 🚫 dangerJS against 25f4f21

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

44.0% Coverage
0.0% Duplication