Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync_response_handler is hammering sentry #7960

Closed
manuroe opened this issue Jan 17, 2023 · 0 comments · Fixed by #7985
Closed

sync_response_handler is hammering sentry #7960

manuroe opened this issue Jan 17, 2023 · 0 comments · Fixed by #7985
Assignees
@bmarty
Labels
A-Telemetry Telemetry / analytics to understand usage O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@manuroe
Copy link
Member

manuroe commented Jan 17, 2023 •
edited
Loading

We should send this analytic event only on initial sync and incremental sync when the app is resumed and not on every /sync request.

It has been introduced by #7514.
@manuroe manuroe added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jan 17, 2023
@manuroe manuroe added the A-Telemetry Telemetry / analytics to understand usage label Jan 17, 2023
@manuroe manuroe added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Jan 17, 2023
@bmarty bmarty mentioned this issue Jan 20, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
A-Telemetry Telemetry / analytics to understand usage O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Slow down sentry element-hq/element-android
2 participants
@bmarty @manuroe