Improve CountUpTimer ticks precision #8058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 1, 2023 18:12
Florian14
added
the
Z-NextRelease
bmarty
approved these changes
Feb 3, 2023
| import java.util.concurrent.atomic.AtomicLong | ||
|
|
||
| @OptIn(kotlinx.coroutines.ExperimentalCoroutinesApi::class) | ||
| class CountUpTimer(initialTime: Long = 0L, private val intervalInMs: Long = 1_000) { | ||
| class CountUpTimer( |
There was a problem hiding this comment.
Since we are not using tickerFlow anymore, I think the @OptIn can be removed.
There was a problem hiding this comment.
|
|
||
| @Test | ||
| fun `when pausing and resuming the timer, the timer ticks the right values at the right moments`() = runTest { | ||
| every { fakeClock.epochMillis() } answers { currentTime } |
There was a problem hiding this comment.
Alternatively we could define a TestClock like this:
@OptIn(ExperimentalCoroutinesApi::class)
class TestClock(private val ts: TestScope) : Clock {
override fun epochMillis(): Long {
return ts.currentTime
}
}(do not change, it's just to share my idea :) ).
|
Added |
|
SonarCloud Quality Gate failed. |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
CountUpTimertick notifications by removing thetickerFlowwhich was introducing delays between each notification and did not notify at the expected timeClockand moved the existing one fromvectormodule tocore-utilsMotivation and context
Fix: #8012 (comment)
Screenshots / GIFs
Tests
Tested devices
Checklist