{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":322936234,"defaultBranch":"main","name":"eframe_template","ownerLogin":"emilk","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2020-12-19T20:54:21.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/1148717?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1720012168.0","currentOid":""},"activityList":{"items":[{"before":"15b99c53fb65799063d8ecde98a121554f7dbb8f","after":"b3d7af7e8f04d62efb87cdaaedd9cfc446ac50b5","ref":"refs/heads/gh-pages","pushedAt":"2024-09-02T07:29:00.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ emilk/eframe_template@ac47eafb17cef09c4b3cb0ba4f523b68367bdd57 ๐Ÿš€","shortMessageHtmlLink":"Deploying to gh-pages from @ ac47eaf ๐Ÿš€"}},{"before":"505682209df564f0687488533accbe86bd56e8e5","after":"ac47eafb17cef09c4b3cb0ba4f523b68367bdd57","ref":"refs/heads/main","pushedAt":"2024-09-02T07:27:41.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"emilk","name":"Emil Ernerfeldt","path":"/emilk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1148717?s=80&v=4"},"commit":{"message":"Update `Cargo.lock` to allow compiling with `wgpu` backend (#160)\n\nThis PR builds upon #159 and updates a few dependencies in `Cargo.lock`\r\nso that `eframe_template` can be compiled with the `wgpu` backend\r\n*without* removing and regenerating `Cargo.lock` from scratch.\r\n\r\nBefore this change, the following compile error occurs after switching\r\nfrom `glow` to `wgpu` backend:\r\n\r\n```\r\nben@Bens-MacBook-Pro eframe_template % cargo check\r\nerror: failed to select a version for `termcolor`.\r\n ... required by package `naga v0.20.0`\r\n ... which satisfies dependency `naga = \"^0.20.0\"` of package `wgpu v0.20.1`\r\n ... which satisfies dependency `wgpu = \"^0.20.0\"` of package `eframe v0.28.0`\r\n ... which satisfies dependency `eframe = \"^0.28\"` (locked to 0.28.0) of package `eframe_template v0.1.0 (/Users/ben/Documents/Fractals/eframe_template)`\r\nversions that meet the requirements `^1.4.1` are: 1.4.1\r\n\r\nall possible versions conflict with previously selected packages.\r\n\r\n previously selected package `termcolor v1.4.0`\r\n ... which satisfies dependency `termcolor = \"^1.1.1\"` (locked to 1.4.0) of package `env_logger v0.10.1`\r\n ... which satisfies dependency `env_logger = \"^0.10\"` (locked to 0.10.1) of package `eframe_template v0.1.0 (/Users/ben/Documents/Fractals/eframe_template)`\r\n\r\nfailed to select a version for `termcolor` which could resolve this conflict\r\n```\r\n\r\nSo I removed the `termcolor` entry from `Cargo.lock` and recompiled so\r\nthat it would choose another version that works:\r\n\r\n```\r\nben@Bens-MacBook-Pro eframe_template % cargo check\r\nerror: failed to select a version for `js-sys`.\r\n ... required by package `wgpu v0.20.1`\r\n ... which satisfies dependency `wgpu = \"^0.20.0\"` of package `eframe v0.28.0`\r\n ... which satisfies dependency `eframe = \"^0.28\"` (locked to 0.28.0) of package `eframe_template v0.1.0 (/Users/ben/Documents/Fractals/eframe_template)`\r\nversions that meet the requirements `^0.3.69` are: 0.3.70, 0.3.69\r\n\r\nall possible versions conflict with previously selected packages.\r\n\r\n previously selected package `js-sys v0.3.66`\r\n ... which satisfies dependency `js-sys = \"^0.3\"` (locked to 0.3.66) of package `eframe v0.28.0`\r\n ... which satisfies dependency `eframe = \"^0.28\"` (locked to 0.28.0) of package `eframe_template v0.1.0 (/Users/ben/Documents/Fractals/eframe_template)`\r\n\r\nfailed to select a version for `js-sys` which could resolve this conflict\r\n```\r\n\r\nThen I did the same for `js-sys` and recompiled:\r\n\r\n```\r\nben@Bens-MacBook-Pro eframe_template % cargo check\r\nerror: failed to select a version for `wasm-bindgen-futures`.\r\n ... required by package `wgpu v0.20.1`\r\n ... which satisfies dependency `wgpu = \"^0.20.0\"` of package `eframe v0.28.0`\r\n ... which satisfies dependency `eframe = \"^0.28\"` (locked to 0.28.0) of package `eframe_template v0.1.0 (/Users/ben/Documents/Fractals/eframe_template)`\r\nversions that meet the requirements `^0.4.42` are: 0.4.43, 0.4.42\r\n\r\nall possible versions conflict with previously selected packages.\r\n\r\n previously selected package `wasm-bindgen-futures v0.4.39`\r\n ... which satisfies dependency `wasm-bindgen-futures = \"^0.4\"` (locked to 0.4.39) of package `eframe_template v0.1.0 (/Users/ben/Documents/Fractals/eframe_template)`\r\n\r\nfailed to select a version for `wasm-bindgen-futures` which could resolve this conflict\r\n```\r\n\r\nAnd finally I did the same for `wasm-bindgen-futures` and recompiled,\r\nand it worked just fine.\r\n\r\nI'm not sure if this is the proper way to resolve this issue. Let me\r\nknow if I should have done something different.","shortMessageHtmlLink":"Update Cargo.lock to allow compiling with wgpu backend (#160)"}},{"before":"ddd91819598e17e1ebc821182922fc3c368c824d","after":"15b99c53fb65799063d8ecde98a121554f7dbb8f","ref":"refs/heads/gh-pages","pushedAt":"2024-09-02T06:56:15.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ emilk/eframe_template@505682209df564f0687488533accbe86bd56e8e5 ๐Ÿš€","shortMessageHtmlLink":"Deploying to gh-pages from @ 5056822 ๐Ÿš€"}},{"before":"18a8e76c2525862216410a0db877833090db3ff5","after":"505682209df564f0687488533accbe86bd56e8e5","ref":"refs/heads/main","pushedAt":"2024-09-02T06:54:30.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"emilk","name":"Emil Ernerfeldt","path":"/emilk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1148717?s=80&v=4"},"commit":{"message":"Pin web-sys dependency to < 0.3.70. (#159)\n\nThis allows `eframe_template` to compile when switching from `glow` to\r\n`wgpu` backend.\r\n\r\nFixes #158.","shortMessageHtmlLink":"Pin web-sys dependency to < 0.3.70. (#159)"}},{"before":"72df26da5077cac801912f04479b39a9590835ce","after":"ddd91819598e17e1ebc821182922fc3c368c824d","ref":"refs/heads/gh-pages","pushedAt":"2024-07-16T04:51:29.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ emilk/eframe_template@18a8e76c2525862216410a0db877833090db3ff5 ๐Ÿš€","shortMessageHtmlLink":"Deploying to gh-pages from @ 18a8e76 ๐Ÿš€"}},{"before":"7fc79c05f11ec316c8284d9402f6fe4c3c70fb10","after":"18a8e76c2525862216410a0db877833090db3ff5","ref":"refs/heads/main","pushedAt":"2024-07-16T04:50:34.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"emilk","name":"Emil Ernerfeldt","path":"/emilk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1148717?s=80&v=4"},"commit":{"message":"Fix assets (#146)\n\nFix\r\nhttps://github.com/emilk/eframe_template/pull/142#issuecomment-2229172436\r\n\r\nNote that only \r\n\r\n```\r\n \r\n \r\n```\r\n\r\nare really used in the final `index.html`","shortMessageHtmlLink":"Fix assets (#146)"}},{"before":"0de42b1b51ed48ec9fab6caf24ae73a01a38d3e6","after":"72df26da5077cac801912f04479b39a9590835ce","ref":"refs/heads/gh-pages","pushedAt":"2024-07-15T06:54:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ emilk/eframe_template@7fc79c05f11ec316c8284d9402f6fe4c3c70fb10 ๐Ÿš€","shortMessageHtmlLink":"Deploying to gh-pages from @ 7fc79c0 ๐Ÿš€"}},{"before":"815288b5d43a5beaba16e53bf9f2a689b664af82","after":"7fc79c05f11ec316c8284d9402f6fe4c3c70fb10","ref":"refs/heads/main","pushedAt":"2024-07-15T06:53:47.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"emilk","name":"Emil Ernerfeldt","path":"/emilk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1148717?s=80&v=4"},"commit":{"message":"Update CI deployment (#139)\n\nAt the moment, it appears that musl targets are not working:\r\nhttps://github.com/rust-windowing/winit/issues/1818\r\nTo use gnu, it's necessary to use glib 2.27, for that, cross need to be\r\ninstalled manually from development branch:\r\nhttps://github.com/cross-rs/cross/issues/1510\r\n\r\n---------\r\n\r\nSigned-off-by: Patrick Josรฉ Pereira ","shortMessageHtmlLink":"Update CI deployment (#139)"}},{"before":"b6b33d1baa27f18fa06fc489ba014962649378d8","after":"0de42b1b51ed48ec9fab6caf24ae73a01a38d3e6","ref":"refs/heads/gh-pages","pushedAt":"2024-07-15T06:45:55.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ emilk/eframe_template@815288b5d43a5beaba16e53bf9f2a689b664af82 ๐Ÿš€","shortMessageHtmlLink":"Deploying to gh-pages from @ 815288b ๐Ÿš€"}},{"before":"96e4908b1c7ba2da6c0527589e5f6e3060f93ee9","after":"815288b5d43a5beaba16e53bf9f2a689b664af82","ref":"refs/heads/main","pushedAt":"2024-07-15T06:44:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"emilk","name":"Emil Ernerfeldt","path":"/emilk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1148717?s=80&v=4"},"commit":{"message":"Don't specify patch version in rust-toolchain file\n\nCloses https://github.com/emilk/eframe_template/issues/145","shortMessageHtmlLink":"Don't specify patch version in rust-toolchain file"}},{"before":"4729cb31ac787aee105b569a809cdaf4526326cd","after":"b6b33d1baa27f18fa06fc489ba014962649378d8","ref":"refs/heads/gh-pages","pushedAt":"2024-07-03T13:17:30.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ emilk/eframe_template@96e4908b1c7ba2da6c0527589e5f6e3060f93ee9 ๐Ÿš€","shortMessageHtmlLink":"Deploying to gh-pages from @ 96e4908 ๐Ÿš€"}},{"before":"cd051d33c7f5c92ff227e0ef0e733db0222714d9","after":"96e4908b1c7ba2da6c0527589e5f6e3060f93ee9","ref":"refs/heads/main","pushedAt":"2024-07-03T13:16:17.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"emilk","name":"Emil Ernerfeldt","path":"/emilk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1148717?s=80&v=4"},"commit":{"message":"Update to egui 0.28.0 (#144)\n\negui 0.28.0 release notes:\r\nhttps://github.com/emilk/egui/releases/tag/0.28.0","shortMessageHtmlLink":"Update to egui 0.28.0 (#144)"}},{"before":null,"after":"49c63106d5d2305ecddb92b9849492eb94b3b402","ref":"refs/heads/emilk/egui-0.28","pushedAt":"2024-07-03T13:07:47.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"emilk","name":"Emil Ernerfeldt","path":"/emilk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1148717?s=80&v=4"},"commit":{"message":"Update to egui 0.28.0","shortMessageHtmlLink":"Update to egui 0.28.0"}},{"before":"d4d5b3290417232d6f60568a022bd0075fcc5e8c","after":"4729cb31ac787aee105b569a809cdaf4526326cd","ref":"refs/heads/gh-pages","pushedAt":"2024-06-30T12:49:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ emilk/eframe_template@cd051d33c7f5c92ff227e0ef0e733db0222714d9 ๐Ÿš€","shortMessageHtmlLink":"Deploying to gh-pages from @ cd051d3 ๐Ÿš€"}},{"before":"eabcffa721a72b074c70a44c704b4b934653c39f","after":"cd051d33c7f5c92ff227e0ef0e733db0222714d9","ref":"refs/heads/main","pushedAt":"2024-06-30T12:48:13.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"emilk","name":"Emil Ernerfeldt","path":"/emilk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1148717?s=80&v=4"},"commit":{"message":"Update pages action to avoid deprecation issues (#143)\n\nThe current pages actions produce a lot of deprecation warnings from\r\ngithub. This should fix that.\r\n\r\n`actions-rs` is also archived and unmaintained. The configuration here\r\nis simple enough to just throw in the commands directly so it's probably\r\na good idea to do that.","shortMessageHtmlLink":"Update pages action to avoid deprecation issues (#143)"}},{"before":"08fb2e3ff670878b7a44fb2e00794cfa8a50ffd3","after":"d4d5b3290417232d6f60568a022bd0075fcc5e8c","ref":"refs/heads/gh-pages","pushedAt":"2024-06-30T12:40:16.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ emilk/eframe_template@eabcffa721a72b074c70a44c704b4b934653c39f ๐Ÿš€","shortMessageHtmlLink":"Deploying to gh-pages from @ eabcffa ๐Ÿš€"}},{"before":"f774883b90ef4a57ee5b0f8541486a563250864a","after":"eabcffa721a72b074c70a44c704b4b934653c39f","ref":"refs/heads/main","pushedAt":"2024-06-30T12:39:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"emilk","name":"Emil Ernerfeldt","path":"/emilk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1148717?s=80&v=4"},"commit":{"message":"Fix typo","shortMessageHtmlLink":"Fix typo"}},{"before":"f34f8c3611e17cb08af622bd8c60e1b3f7cdbc3b","after":"08fb2e3ff670878b7a44fb2e00794cfa8a50ffd3","ref":"refs/heads/gh-pages","pushedAt":"2024-06-27T07:47:50.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ emilk/eframe_template@f774883b90ef4a57ee5b0f8541486a563250864a ๐Ÿš€","shortMessageHtmlLink":"Deploying to gh-pages from @ f774883 ๐Ÿš€"}},{"before":"098d4ee67bbea13e9e3c72ec3d2576f01b9a8830","after":"f774883b90ef4a57ee5b0f8541486a563250864a","ref":"refs/heads/main","pushedAt":"2024-06-27T07:46:53.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"emilk","name":"Emil Ernerfeldt","path":"/emilk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1148717?s=80&v=4"},"commit":{"message":"Fix `index.html` links to `manifest` and `apple-touch-icon` (#142)\n\n## Bug: assets have incorrect paths\r\n\r\nProof:\r\n\r\n```\r\ngit clone https://github.com/emilk/eframe_template.git && lychee .\r\n```\r\n\r\n```\r\n 31/31 โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ” Finished extracting links Issues found in 1 input. Find details below.\r\n\r\n[./eframe_template/index.html]:\r\nโœ— [ERR] file:///tmp/tmp.xuDXKdo4H8/eframe_template/icon_ios_touch_192.png | Failed: Cannot find file\r\nโœ— [ERR] file:///tmp/tmp.xuDXKdo4H8/eframe_template/manifest.json | Failed: Cannot find file\r\n\r\n๐Ÿ” 31 Total (in 0s) โœ… 29 OK ๐Ÿšซ 2 Errors\r\n\r\n```\r\n\r\n\r\n## Fix\r\n\r\nchange links to these assets\r\n\r\n\r\n## Related to\r\n\r\n- https://github.com/emilk/eframe_template/pull/137\r\n- related to\r\nhttps://github.com/rerun-io/ewebsock/pull/38#issuecomment-2150380393","shortMessageHtmlLink":"Fix index.html links to manifest and apple-touch-icon (#142)"}},{"before":"3b5e3f7ae318364acca6a0cd4e11d74555122508","after":"f34f8c3611e17cb08af622bd8c60e1b3f7cdbc3b","ref":"refs/heads/gh-pages","pushedAt":"2024-06-26T19:32:31.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ emilk/eframe_template@098d4ee67bbea13e9e3c72ec3d2576f01b9a8830 ๐Ÿš€","shortMessageHtmlLink":"Deploying to gh-pages from @ 098d4ee ๐Ÿš€"}},{"before":"c4be564503ae0db2ea5e01e579f5e48635dae5d7","after":"3b5e3f7ae318364acca6a0cd4e11d74555122508","ref":"refs/heads/gh-pages","pushedAt":"2024-06-26T19:31:08.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ emilk/eframe_template@00ff8b26403ada3b62aaa0eda2f290f19f6329eb ๐Ÿš€","shortMessageHtmlLink":"Deploying to gh-pages from @ 00ff8b2 ๐Ÿš€"}},{"before":"00ff8b26403ada3b62aaa0eda2f290f19f6329eb","after":"098d4ee67bbea13e9e3c72ec3d2576f01b9a8830","ref":"refs/heads/main","pushedAt":"2024-06-26T19:29:44.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"emilk","name":"Emil Ernerfeldt","path":"/emilk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1148717?s=80&v=4"},"commit":{"message":"Add a `flake.nix` (#72)\n\nThis will make it far easier to get started with eframe/egui. Simply\r\nrunning the following command will (hopefully) set up a working\r\nenvironment: `nix --experimental-features 'nix-command flakes' develop`\r\n(if Nix is installed)","shortMessageHtmlLink":"Add a flake.nix (#72)"}},{"before":"b090f330e580ad3bc23738af2e1aa687a7ede22b","after":"c4be564503ae0db2ea5e01e579f5e48635dae5d7","ref":"refs/heads/gh-pages","pushedAt":"2024-06-26T19:29:42.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ emilk/eframe_template@6ec4bd5ba6a9f5c6b022869b376fb973d028382c ๐Ÿš€","shortMessageHtmlLink":"Deploying to gh-pages from @ 6ec4bd5 ๐Ÿš€"}},{"before":"8e32794222f20aea7a74a4226f4251f4d2f9e686","after":"b090f330e580ad3bc23738af2e1aa687a7ede22b","ref":"refs/heads/gh-pages","pushedAt":"2024-06-26T19:29:40.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ emilk/eframe_template@3a6b565c17c8676823ee25d7a2ab15e0cd40b814 ๐Ÿš€","shortMessageHtmlLink":"Deploying to gh-pages from @ 3a6b565 ๐Ÿš€"}},{"before":"6ec4bd5ba6a9f5c6b022869b376fb973d028382c","after":"00ff8b26403ada3b62aaa0eda2f290f19f6329eb","ref":"refs/heads/main","pushedAt":"2024-06-26T19:28:48.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"emilk","name":"Emil Ernerfeldt","path":"/emilk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1148717?s=80&v=4"},"commit":{"message":"Provide a fill_template script (#77)\n\nHi.\r\n\r\nI think this template project is a wonderful idea to play around with\r\negui for ealuationa nd eventually starting something real with it.\r\n\r\nBut I found it kind of cumbersome to fill in the template consistently\r\nover all the files, so I wrote this little script I would like to share,\r\nin case it is deemed useful.","shortMessageHtmlLink":"Provide a fill_template script (#77)"}},{"before":"3a6b565c17c8676823ee25d7a2ab15e0cd40b814","after":"6ec4bd5ba6a9f5c6b022869b376fb973d028382c","ref":"refs/heads/main","pushedAt":"2024-06-26T19:27:38.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"emilk","name":"Emil Ernerfeldt","path":"/emilk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1148717?s=80&v=4"},"commit":{"message":"Reintroduce the loading spinner (#107)\n\n## Context / before\r\n- The loading spinner (and loading text) were removed in\r\nd12c19da37de943d06703bec09613cf7121a70f9\r\n- If `WebRunner::start` fails nothing is shown in HTML, the user has to\r\nopen the console to see if something happened (a.k.a. halting problem)\r\n\r\n## What changed / now\r\n- before the canvas is loaded a CSS loading spinner with \"Loading...\"\r\ntext is displayed\r\n- if the loading fails, \"the app has crashed\" text is shown instead\r\n - still `panic!` in this case (as it did)\r\n- the corresponding div is removed after loading successfully completes\r\n\r\n\r\n## How does it look\r\n\r\n![image](https://github.com/emilk/eframe_template/assets/58441256/012ef5ec-3e3a-48ca-8971-5fb0afcad738)\r\n\r\n![image](https://github.com/emilk/eframe_template/assets/58441256/c2ed1dc9-eec8-4bd5-b134-9a7cf6ab72e5)\r\n\r\n## What exactly changed\r\n- introduce dependency to `web-sys`\r\n- add the `loading_text` div that shows the spinner text during loading,\r\nor error if loading fails\r\n- access the DOM (in `main.rs`) after the app has been loaded, and\r\nremove the spinner, or show an error\r\n- if we fail to locate `loading_text` (like when someone removes the div\r\nfrom `index.html`) - nothing happens\r\n\r\n## Discussion\r\n- I wanted to avoid dependency on `web-sys`, but, I don't see any other\r\nsimple way to access the spinner\r\n- Another idea I had was to do it straight from the `js` side (like it\r\nwas before), however, I don't see a way to receive events from\r\n`WebRunner`\r\n- If this solution is undesired, I think the CSS remnants of the spinner\r\n[should be\r\nremoved](https://github.com/emilk/eframe_template/compare/master...sedsedus:eframe_template:remove-left-over-css)\r\n(like `lds-dual-ring`)\r\n\r\n## Alternative solution\r\nA more thorough solution (in `main.rs`) is\r\nhttps://github.com/emilk/eframe_template/compare/master...sedsedus:eframe_template:fix-css-spinner-install-hook,\r\nwhere all panics are caught to show HTML error.\r\nI encountered this myself, where I would mistype the canvas id and wait\r\na few seconds wondering why the app doesn't load, only to discover in\r\nthe console that something failed.\r\nThis is more thorough (but at the same time a little more complex / less\r\nclean due to hook insertion) because this \"invalid canvas id error\"\r\nwouldn't get caught by the proposal in this PR\r\n\r\n---------\r\n\r\nCo-authored-by: Emil Ernerfeldt ","shortMessageHtmlLink":"Reintroduce the loading spinner (#107)"}},{"before":"d2bb6a7114292da8e3bb97f6506612b8136799f0","after":"3a6b565c17c8676823ee25d7a2ab15e0cd40b814","ref":"refs/heads/main","pushedAt":"2024-06-26T19:26:36.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"emilk","name":"Emil Ernerfeldt","path":"/emilk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1148717?s=80&v=4"},"commit":{"message":"Fix typo in Cargo.toml (#121)\n\nJust a single typo.\r\n\r\n---------\r\n\r\nCo-authored-by: Emil Ernerfeldt ","shortMessageHtmlLink":"Fix typo in Cargo.toml (#121)"}},{"before":"1e0cc831197a6afeaa104244eee22086309e384d","after":"8e32794222f20aea7a74a4226f4251f4d2f9e686","ref":"refs/heads/gh-pages","pushedAt":"2024-04-21T17:36:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ emilk/eframe_template@d2bb6a7114292da8e3bb97f6506612b8136799f0 ๐Ÿš€","shortMessageHtmlLink":"Deploying to gh-pages from @ d2bb6a7 ๐Ÿš€"}},{"before":"ab640bea84d8cc6ea8709bff13a9a37e182e425f","after":"d2bb6a7114292da8e3bb97f6506612b8136799f0","ref":"refs/heads/main","pushedAt":"2024-04-21T17:35:49.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"emilk","name":"Emil Ernerfeldt","path":"/emilk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1148717?s=80&v=4"},"commit":{"message":"Fix link to eframe (#130)\n\nThe name of the primary branch in the upstream Repo is master not main.\r\nThis PR fixes the link. Alternatively the name of the primary branch\r\ncould just be changed to main as well.","shortMessageHtmlLink":"Fix link to eframe (#130)"}},{"before":"08b2ca18b0bdaa5c1ab5d9cf598847b1b2692bd0","after":"1e0cc831197a6afeaa104244eee22086309e384d","ref":"refs/heads/gh-pages","pushedAt":"2024-04-18T11:26:58.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ emilk/eframe_template@ab640bea84d8cc6ea8709bff13a9a37e182e425f ๐Ÿš€","shortMessageHtmlLink":"Deploying to gh-pages from @ ab640be ๐Ÿš€"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0wMlQwNzoyOTowMC4wMDAwMDBazwAAAASqTSQs","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0wMlQwNzoyOTowMC4wMDAwMDBazwAAAASqTSQs","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNC0xOFQxMToyNjo1OC4wMDAwMDBazwAAAAQ0DyMf"}},"title":"Activity ยท emilk/eframe_template"}