Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛: Pipetest: No circuit diagrams #1018

Open
MagnusGjosund opened this issue May 13, 2024 · 3 comments · May be fixed by #1019
Open

🐛: Pipetest: No circuit diagrams #1018

MagnusGjosund opened this issue May 13, 2024 · 3 comments · May be fixed by #1019
Assignees
@Gustav-Eikaas
Labels
blocked bug Something isn't working

Comments

@MagnusGjosund
Copy link
Contributor

Description

There is no circuit diagrams in any pipetest sidesheets. Seems like the it's not correctly implemented in frontend and backend

Reproduce

Check any pipetest sidesheet

Expected behavior

Get the circuit diagram for the tags (heat traces?) involved in the pipetest
@MagnusGjosund MagnusGjosund added the bug Something isn't working label May 13, 2024
@Gustav-Eikaas
Copy link
Contributor

Gustav-Eikaas commented May 13, 2024 •
edited
Loading

Seems the change was introduced when removing eleconsumers

frontend: https://github.com/equinor/cc-components/pull/929/files#diff-beb2e7c2803df85bdd636706f71d4b5c37b2e664569ccd457b6b68e4ed2dbb27R12

Backend: https://github.com/equinor/fusion-data-gateway/pull/528/files#diff-5a4b71e787941f79d19412d43d7032fad467ec12eddbee19146af79b1cd93b67R11-R12

Not sure what happened here though. Seems like just a mistake.

Seems like the solution here is to add an endpoint in pipetest that returns what the old endpoint used to return

@Gustav-Eikaas Gustav-Eikaas linked a pull request May 13, 2024 that will close this issue
fix: piptest electrical-network endpoint #1019
Draft
@Gustav-Eikaas
Copy link
Contributor

Changes are done but there seems to be an issue with the data, only few of the pipetest objects have heattrace relations.

Currently investigating with @aman-riaz

@Gustav-Eikaas Gustav-Eikaas self-assigned this May 14, 2024
@Gustav-Eikaas Gustav-Eikaas added unplanned Bugs or issues that has to be resolved quickly and were not planned into a sprint on-hold blocked and removed on-hold labels May 14, 2024
@Gustav-Eikaas
Copy link
Contributor

After investigating with Aman; We need to do some changes in the SQL view.

@ken-mellem ken-mellem removed the unplanned Bugs or issues that has to be resolved quickly and were not planned into a sprint label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gustav-Eikaas Gustav-Eikaas

Labels
blocked bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: piptest electrical-network endpoint equinor/cc-components
3 participants
@MagnusGjosund @Gustav-Eikaas @ken-mellem