Add a LogObserver() function to Member interface

[clement2026]

What would you like to be added?

Add a LogObserver() function to Member interface.

etcd/tests/framework/interfaces/interface.go

Lines 39 to 43 in 4bb9392

	type Member interface {
	Client() Client
	Start(ctx context.Context) error
	Stop()
	}

It may look something like this:

 type Member interface { 
 	Client() Client 
 	Start(ctx context.Context) error 
 	Stop() 
        LogObserver()  LogObserver         <<< here
 } 

Why is this needed?

I was writing a test that waits for events by watching logs. Then I noticed both e2e test and integration test have their own log observer implementations.

etcd/tests/framework/integration/cluster.go

Lines 549 to 589 in 4bb9392

	type Member struct {
	config.ServerConfig
	UniqNumber int
	MemberNumber int
	Port string
	PeerListeners, ClientListeners []net.Listener
	GRPCListener net.Listener
	// PeerTLSInfo enables peer TLS when set
	PeerTLSInfo *transport.TLSInfo
	// ClientTLSInfo enables client TLS when set
	ClientTLSInfo *transport.TLSInfo
	DialOptions []grpc.DialOption
	RaftHandler *testutil.PauseableHandler
	Server *etcdserver.EtcdServer
	ServerClosers []func()
	GRPCServerOpts []grpc.ServerOption
	GRPCServer *grpc.Server
	GRPCURL string
	GRPCBridge *bridge
	// ServerClient is a clientv3 that directly calls the etcdserver.
	ServerClient *clientv3.Client
	// Client is a clientv3 that communicates via socket, either UNIX or TCP.
	Client *clientv3.Client
	KeepDataDirTerminate bool
	ClientMaxCallSendMsgSize int
	ClientMaxCallRecvMsgSize int
	UseIP bool
	UseBridge bool
	UseTCP bool
	IsLearner bool
	Closed bool
	GRPCServerRecorder *grpctesting.GRPCRecorder
	LogObserver *testutils.LogObserver
	}

etcd/tests/framework/e2e/etcd_process.go

Lines 45 to 69 in 4bb9392

	type EtcdProcess interface {
	EndpointsGRPC() []string
	EndpointsHTTP() []string
	EndpointsMetrics() []string
	Etcdctl(opts ...config.ClientOption) *EtcdctlV3
	IsRunning() bool
	Wait(ctx context.Context) error
	Start(ctx context.Context) error
	Restart(ctx context.Context) error
	Stop() error
	Close() error
	Config() *EtcdServerProcessConfig
	PeerProxy() proxy.Server
	Failpoints() *BinaryFailpoints
	LazyFS() *LazyFS
	Logs() LogsExpect
	Kill() error
	}
	type LogsExpect interface {
	ExpectWithContext(context.Context, expect.ExpectedResponse) (string, error)
	Lines() []string
	LineCount() int
	}

Would it be a good idea to add a LogObserver() function to Member interface? This way, I can rewrite the test to work for both e2e and integration tests.

[anishbista60]

/assign

[serathius]

I don't think it will be easy as for integration tests you cannot easily collect logs. You need inject a logger that does it for you.