-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why move to axios? #92
Comments
this should be changed since it's a good 2 megabytes now. |
The intention was for v4 to serve as a more minimal library for Axios compatibility while providing a similar and mostly backwards compatible API. I see the feedback and am open to discontinuing v4 (deprecating it, I guess?) and releasing a new version of v3 which includes fixes. |
Since you have not elaborated what the reasons for deprecating the project were in the first place, i can only assume you can not afford the time or energy to maintain it. Please correct me here if i'm wrong. Whatever your reasons are, i'm certain they are valid and stepping down from a project to put other priorities forward is absolutely fine. However, i wish there had been an announcement before deprecating the project. I do not know if you have made any non-public effort to find a new maintainer for phin. My hope would be for you to find a new maintainer instead of the efforts that have been made. I think i understand why you put out the "axios-version", but since the "selling-point" of phin has always been it's lightweightedness i feel this was misguided. Anyway, there are still ways forward, if you do not want to continue to be the maintainer of phin (or contribute at a lesser capacity): Find a new maintainer to care about issues, pull requests, security reports and the boring day-to-day bits, maybe while staying the owner of the project and retain control of the package. I can think about offering my help to do at least some "spring cleaning" with regards to the open issues and pull requests. |
That's right, it's mainly due to time constraints on my end and not using Node.js regularly anymore. I appreciate your suggestions and the offer to help with maintaining the library. Keep an eye out for future updates. I'm hoping to officially pass the torch to new maintainer(s) soon, after wrapping up some things. |
What was wrong with the previous (centra based) code?
Is there a security issue that required this drastic change?
Otherwise why not leave the code as is?
The text was updated successfully, but these errors were encountered: