Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert RCTContextExecutor to use a dispatch queue instead of a thread #75

Closed
ide opened this issue Feb 17, 2015 · 1 comment
Closed
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@ide
Copy link
Contributor

ide commented Feb 17, 2015

This is a mostly straightforward task but may need some changes from Facebook's side if there is existing code calling into -[initWithJavaScriptThread:globalContextRef:]. The only tricky thing I see is the check in dealloc to see if the current thread is the JS thread. That could be replaced with dispatch_queue_set_specific and dispatch_get_specific, or dealloc could simply always dispatch_async. I'm also not sure it's needed at all since JSC should be thread-safe.

@ide
Copy link
Contributor Author

ide commented May 29, 2015

Closing this out because queues and run loops don't mix. Still wish we could use queues in the executor though.

@ide ide closed this as completed May 29, 2015
@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

2 participants