From edb4289cc6266173a682297aeaa78fc04c4e886d Mon Sep 17 00:00:00 2001 From: Can Balioglu Date: Tue, 21 Nov 2023 20:28:03 -0500 Subject: [PATCH] Improve error messaging for name resolution failure (#174) --- src/fairseq2/assets/download_manager.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/fairseq2/assets/download_manager.py b/src/fairseq2/assets/download_manager.py index d27c8be8a..02ecd607b 100644 --- a/src/fairseq2/assets/download_manager.py +++ b/src/fairseq2/assets/download_manager.py @@ -14,7 +14,7 @@ from tarfile import TarFile, is_tarfile from tempfile import NamedTemporaryFile from typing import Dict, Optional, final -from urllib.error import HTTPError +from urllib.error import HTTPError, URLError from urllib.parse import unquote, urlparse from urllib.request import Request, urlopen from zipfile import BadZipFile, ZipFile @@ -368,6 +368,10 @@ def remove_cache_dir() -> None: try: response = cleanup_stack.enter_context(urlopen(request)) + except URLError as ex: + raise AssetDownloadError( + f"The download of the {self.display_name} has failed. See nested exception for details." + ) from ex except HTTPError as ex: raise AssetDownloadError( f"The download of the {self.display_name} has failed with the HTTP error code {ex.code}."