{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":253935264,"defaultBranch":"main","name":"pplbench","ownerLogin":"facebookresearch","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2020-04-07T23:24:59.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/16943930?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1693002953.0","currentOid":""},"activityList":{"items":[{"before":"1f2db20e79950c2ab13746e897277e9bf2c8cacc","after":"3023989cf05e96c3316046c40a9745f8628de5eb","ref":"refs/heads/main","pushedAt":"2023-08-30T21:35:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Back out \"remove unsupported/unused benchmarks that cause test warnings in production diffs\"\n\nSummary:\nReason for the undo: The change in the original diff led to the deletion of the entire repo content on GitHub: https://github.com/facebookresearch/pplbench/commit/1f2db20e79950c2ab13746e897277e9bf2c8cacc\n\nThis is because ShipIt is configured to sync to GitHub: https://www.internalfb.com/code/configerator/source/opensource/shipit_config/facebookresearch/pplbench.cconf?lines=10\n\nThe suggested strategy to resolve this situation is now:\n1. Land the present diff.\n2. Wait for the GitHub repo to receive the undo.\n3. Remove the ShipIt config.\n4. Re-do the change in  D48647611.\n\n----\nAlternative plan:\n1. Undo the deletion commit/PR on GitHub.\n2. Remove the ShipIt config.\n3. No need to undo and redo the change in the Meta repos.\n\nHowever, I don't think I have the permissions to perform the actions on GitHub, so the alternative plan would have to be executed by someone else.\n\n----\nOriginal commit changeset: b41d436b2838\n\nOriginal Phabricator Diff: D48647611\n\nReviewed By: ToddSmall\n\nDifferential Revision: D48819817\n\nfbshipit-source-id: 8189115e9de93c5230fa44289d5a9f968b281892","shortMessageHtmlLink":"Back out \"remove unsupported/unused benchmarks that cause test warnin…"}},{"before":"1f2db20e79950c2ab13746e897277e9bf2c8cacc","after":"f5690816a5e4c113e3d584384c0a5572b0e6b579","ref":"refs/heads/automated_fixup_code_of_conduct_file_exists","pushedAt":"2023-08-25T22:35:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"OSS Automated Fix: Addition of Code of Conduct","shortMessageHtmlLink":"OSS Automated Fix: Addition of Code of Conduct"}},{"before":null,"after":"1f2db20e79950c2ab13746e897277e9bf2c8cacc","ref":"refs/heads/automated_fixup_code_of_conduct_file_exists","pushedAt":"2023-08-25T22:35:53.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"remove unsupported/unused benchmarks that cause test warnings in production diffs\n\nSummary:\n**For now, this is an RFC (request for comments).**\nIf you are interested in maintaining the code suggested for deletion here, please step up.\n\nThe code in `pplbench` causes warnings in diffs like D48606875. This causes distractions when trying to ship diffs.\n\n {F1075724799}\n\nClicking through the logs identifies `pplbench` as the culprit: {F1075724803}\n\nIn the interest of keeping a good signal/noise ratio, I suggest to remove this code -- unless someone is willing to step up and maintain it. As far as I can tell, it does not serve any production purpose here at Meta.\n\n=== Source syncing note ===\n\nStarting in February, the source of truth of the Beanmachine open source project was switched from Meta internal to GitHub, ShipIt was deactivated in D43404340.\n\nThe `benchmarks/` directory does not show up on [GitHub](https://github.com/facebookresearch/beanmachine), so I assume this part is not synced.\n\nReviewed By: ToddSmall\n\nDifferential Revision: D48647611\n\nfbshipit-source-id: b41d436b283808217b7736cf82d13a76dcc30713","shortMessageHtmlLink":"remove unsupported/unused benchmarks that cause test warnings in prod…"}},{"before":"1f2db20e79950c2ab13746e897277e9bf2c8cacc","after":"3cb167d445c79c9e9d8b7e38a10bfc9811d788c9","ref":"refs/heads/automated_fixup_contributing_file_exists","pushedAt":"2023-08-25T22:32:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"OSS Automated Fix: Addition of Contributing","shortMessageHtmlLink":"OSS Automated Fix: Addition of Contributing"}},{"before":null,"after":"1f2db20e79950c2ab13746e897277e9bf2c8cacc","ref":"refs/heads/automated_fixup_contributing_file_exists","pushedAt":"2023-08-25T22:32:42.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"remove unsupported/unused benchmarks that cause test warnings in production diffs\n\nSummary:\n**For now, this is an RFC (request for comments).**\nIf you are interested in maintaining the code suggested for deletion here, please step up.\n\nThe code in `pplbench` causes warnings in diffs like D48606875. This causes distractions when trying to ship diffs.\n\n {F1075724799}\n\nClicking through the logs identifies `pplbench` as the culprit: {F1075724803}\n\nIn the interest of keeping a good signal/noise ratio, I suggest to remove this code -- unless someone is willing to step up and maintain it. As far as I can tell, it does not serve any production purpose here at Meta.\n\n=== Source syncing note ===\n\nStarting in February, the source of truth of the Beanmachine open source project was switched from Meta internal to GitHub, ShipIt was deactivated in D43404340.\n\nThe `benchmarks/` directory does not show up on [GitHub](https://github.com/facebookresearch/beanmachine), so I assume this part is not synced.\n\nReviewed By: ToddSmall\n\nDifferential Revision: D48647611\n\nfbshipit-source-id: b41d436b283808217b7736cf82d13a76dcc30713","shortMessageHtmlLink":"remove unsupported/unused benchmarks that cause test warnings in prod…"}},{"before":"48ba1eee13ed72dc9c744efc3781c73b4419f15e","after":"1f2db20e79950c2ab13746e897277e9bf2c8cacc","ref":"refs/heads/main","pushedAt":"2023-08-25T07:29:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"remove unsupported/unused benchmarks that cause test warnings in production diffs\n\nSummary:\n**For now, this is an RFC (request for comments).**\nIf you are interested in maintaining the code suggested for deletion here, please step up.\n\nThe code in `pplbench` causes warnings in diffs like D48606875. This causes distractions when trying to ship diffs.\n\n {F1075724799}\n\nClicking through the logs identifies `pplbench` as the culprit: {F1075724803}\n\nIn the interest of keeping a good signal/noise ratio, I suggest to remove this code -- unless someone is willing to step up and maintain it. As far as I can tell, it does not serve any production purpose here at Meta.\n\n=== Source syncing note ===\n\nStarting in February, the source of truth of the Beanmachine open source project was switched from Meta internal to GitHub, ShipIt was deactivated in D43404340.\n\nThe `benchmarks/` directory does not show up on [GitHub](https://github.com/facebookresearch/beanmachine), so I assume this part is not synced.\n\nReviewed By: ToddSmall\n\nDifferential Revision: D48647611\n\nfbshipit-source-id: b41d436b283808217b7736cf82d13a76dcc30713","shortMessageHtmlLink":"remove unsupported/unused benchmarks that cause test warnings in prod…"}},{"before":null,"after":"ba3c1fa2b1ff5f9e8e4aeeec6093de161e7b5d22","ref":"refs/heads/dependabot/npm_and_yarn/website/word-wrap-1.2.4","pushedAt":"2023-07-19T00:05:33.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump word-wrap from 1.2.3 to 1.2.4 in /website\n\nBumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.\n- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)\n- [Commits](https://github.com/jonschlinkert/word-wrap/compare/1.2.3...1.2.4)\n\n---\nupdated-dependencies:\n- dependency-name: word-wrap\n  dependency-type: indirect\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"Bump word-wrap from 1.2.3 to 1.2.4 in /website"}},{"before":null,"after":"96074a7b2f8084543761323dbf4a35732a265f1f","ref":"refs/heads/dependabot/npm_and_yarn/website/semver-5.7.2","pushedAt":"2023-07-11T00:45:40.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump semver from 5.7.1 to 5.7.2 in /website\n\nBumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2.\n- [Release notes](https://github.com/npm/node-semver/releases)\n- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)\n- [Commits](https://github.com/npm/node-semver/compare/v5.7.1...v5.7.2)\n\n---\nupdated-dependencies:\n- dependency-name: semver\n  dependency-type: indirect\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"Bump semver from 5.7.1 to 5.7.2 in /website"}},{"before":null,"after":"6f45da9861c45384999bf4bc5a049e590331212e","ref":"refs/heads/dependabot/npm_and_yarn/website/stylelint-15.10.1","pushedAt":"2023-07-07T21:30:29.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump stylelint from 13.7.2 to 15.10.1 in /website\n\nBumps [stylelint](https://github.com/stylelint/stylelint) from 13.7.2 to 15.10.1.\n- [Release notes](https://github.com/stylelint/stylelint/releases)\n- [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md)\n- [Commits](https://github.com/stylelint/stylelint/compare/13.7.2...15.10.1)\n\n---\nupdated-dependencies:\n- dependency-name: stylelint\n  dependency-type: direct:development\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"Bump stylelint from 13.7.2 to 15.10.1 in /website"}},{"before":"19de5b23c4167fef259fe3b61f4bb08a37f5ebad","after":"48ba1eee13ed72dc9c744efc3781c73b4419f15e","ref":"refs/heads/main","pushedAt":"2023-04-12T20:56:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Replace hasattr with getattr in beanmachine/benchmarks/pplbench/pplbench/lib/model_helper.py\n\nSummary:\nThe pattern\n```\nX.Y if hasattr(X, \"Y\") else Z\n```\ncan be replaced with\n```\ngetattr(X, \"Y\", Z)\n```\n\nThe [getattr](https://www.w3schools.com/python/ref_func_getattr.asp) function gives more succinct code than the [hasattr](https://www.w3schools.com/python/ref_func_hasattr.asp) function. Please use it when appropriate.\n\n**This diff is very low risk. Green tests indicate that you can safely Accept & Ship.**\n\nReviewed By: kshah1997\n\nDifferential Revision: D44886419\n\nfbshipit-source-id: 30ee87302123b330fba802212fa41ca5952629d6","shortMessageHtmlLink":"Replace hasattr with getattr in beanmachine/benchmarks/pplbench/pplbe…"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyMy0wOC0zMFQyMTozNTo0MS4wMDAwMDBazwAAAAN2Htdx","startCursor":"Y3Vyc29yOnYyOpK7MjAyMy0wOC0zMFQyMTozNTo0MS4wMDAwMDBazwAAAAN2Htdx","endCursor":"Y3Vyc29yOnYyOpK7MjAyMy0wNC0xMlQyMDo1Njo0OS4wMDAwMDBazwAAAAMXfT2g"}},"title":"Activity · facebookresearch/pplbench"}