Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaussian divergence for slit source #213

Closed
kdreher opened this issue Mar 8, 2024 · 3 comments · Fixed by #214
Closed

Gaussian divergence for slit source #213

kdreher opened this issue Mar 8, 2024 · 3 comments · Fixed by #214

Comments

@kdreher
Copy link

kdreher commented Mar 8, 2024

Currently, the slit source is defined with a single-direction vector for all photons meaning that all photons launched from that source will have the exact same direction. In reality, however, e.g. a laser slit will have some Gaussian-like intensity distribution instead of a collimated, sharply defined slit.
The option to include a beam divergence angle in the source parameters to model this behaviour would be really nice. Usually, these angles can be measured for a real laser slit at its full-width-at-half maximum.

This feature could help model a digital twin of these slit sources more exactly.

@fangq
Copy link
Owner

fangq commented Mar 10, 2024

I've merged the patch and added a follow up commit to reduce register use.

Please test the updated code and verify if the new source still works as expected. Once verified, feel free to close this ticket.

thanks for contributing!

@lkeegan
Copy link
Contributor

lkeegan commented Mar 11, 2024

I tested the master branch and it all works great, many thanks!

@kdreher
Copy link
Author

kdreher commented Mar 11, 2024

Great, I also tested it and it seems to run perfectly! Thanks for the fast response!

@kdreher kdreher closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants