Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError: Cannot read property 'dataset' of null #336

Closed
esparkman opened this issue Apr 22, 2016 · 4 comments
Closed

Uncaught TypeError: Cannot read property 'dataset' of null #336

esparkman opened this issue Apr 22, 2016 · 4 comments
Assignees
Labels
bug Confirmed defect in package logic, deprecation notices, and PRs which fix them.

Comments

@esparkman
Copy link

[Enter steps to reproduce below:]

  1. ...
  2. ...

Atom Version: 1.7.2
System: Mac OS X 10.11.4
Thrown From: file-icons package, v1.7.6

Stack Trace

Uncaught TypeError: Cannot read property 'dataset' of null

At /Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:1002

TypeError: Cannot read property 'dataset' of null
    at /Users/evansparkman/.atom/packages/file-icons/index.coffee:67:18
    at Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:125:28)
    at TextBuffer.module.exports.TextBuffer.saveAs (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/text-buffer.js:1104:27)
    at TextEditor.module.exports.TextEditor.saveAs (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor.js:666:26)
    at Pane.module.exports.Pane.saveItemAs (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:742:16)
    at Pane.module.exports.Pane.saveItem (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:726:21)
    at Pane.module.exports.Pane.saveActiveItem (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:701:19)
    at Workspace.module.exports.Workspace.saveActivePaneItem (/Applications/Atom.app/Contents/Resources/app.asar/src/workspace.js:684:35)
    at atom-workspace.commandRegistry.add.core:save (/Applications/Atom.app/Contents/Resources/app.asar/src/register-default-commands.js:214:32)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:260:29)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:580:16)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:388:22)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:98:36)
    at HTMLDocument.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:3:61)

Commands

     -0:23.3.0 application:new-file (atom-pane.pane.active)
     -0:20 core:save (atom-text-editor.editor.is-focused)
     -0:07.7.0 application:new-file (atom-text-editor.editor.is-focused)
     -0:04.1.0 core:save (atom-text-editor.editor.is-focused)

Config

{
  "core": {
    "disabledPackages": [
      "tablr"
    ]
  }
}

Installed Packages

# User
file-icons, v1.7.6
indent-guide-improved, v1.4.5
language-babel, v2.17.3
linter, v1.11.4
linter-eslint, v7.2.1
sublime-panes, v0.2.5

# Dev
No dev packages
@fserb
Copy link

fserb commented Apr 23, 2016

Same here.

@Alhadis
Copy link
Member

Alhadis commented Apr 23, 2016

Seems related to the sublime-panes package. I wasn't able to reproduce until I installed it.

@Alhadis Alhadis added the bug Confirmed defect in package logic, deprecation notices, and PRs which fix them. label Apr 23, 2016
@Alhadis Alhadis self-assigned this Apr 23, 2016
@Alhadis
Copy link
Member

Alhadis commented Apr 23, 2016

@esparkman / @fserb Could you two tell me the values of the following core settings?

  1. Allow Pending Pane Items
  2. Close Empty Windows
  3. Remove Empty Panes

FYI, I noticed the sublime-panes package hasn't been updated since August 2015, which is long before Atom added the pending items feature to its core. I've already noticed it's thrown a number of errors when opening/closing files...

@Alhadis
Copy link
Member

Alhadis commented Apr 23, 2016

Right. Should be fixed.

I'll publish a patch release; please let me know if this happens again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed defect in package logic, deprecation notices, and PRs which fix them.
Projects
None yet
Development

No branches or pull requests

3 participants