Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"skipFirstLoad: true" Doesn't Work? #190

Closed
JimLynchCodes opened this issue Apr 11, 2020 · 7 comments · Fixed by #191, WFCD/genesis#322 or WFCD/worldstate-emitter#25
Closed

"skipFirstLoad: true" Doesn't Work? #190

JimLynchCodes opened this issue Apr 11, 2020 · 7 comments · Fixed by #191, WFCD/genesis#322 or WFCD/worldstate-emitter#25
Labels

Comments

@JimLynchCodes
Copy link

Hi, I am using this code:

const RssFeedEmitter = require('rss-feed-emitter');
const feeder = new RssFeedEmitter({ skipFirstLoad: true });

feeder.add({
    url: 'http://www.nintendolife.com/feeds/news',
    refresh: 2000
});


feeder.on('new-item', function (item) {
    console.log(item);
})

console.log('Feed watcher bot is listening... ')

but it returns a whole mountain of posts. I would think it shouldn't return anything but the console.log statement since the skipFirstLoad: true was passed in... 🤔

@JimLynchCodes
Copy link
Author

using node v12.16.1 and rss-feed-emitter v3.1.0

@JimLynchCodes
Copy link
Author

same result with node v11.15.0... 😢

@TobiTenno
Copy link
Collaborator

our unit tests seem to think it works fine

@midzer
Copy link
Contributor

midzer commented Apr 12, 2020

Can confirm this issue

@djholt
Copy link

djholt commented Apr 13, 2020

I can confirm this also.

@mfreiwald
Copy link

this.populateNewItemsInFeed(data);

Must be changed to this.populateNewItemsInFeed(data, firstLoad);

@filipedeschamps
Copy link
Owner

🎉 This issue has been resolved in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants