Fixing FeedEmitter missing "eventName" property type

[0xWryth]

FeedEmitter was missing eventName property type which was causing issue while working with Typescript.
Optional eventName has been added.

[0xWryth]

@filipedeschamps, it seems that Travis is failing should emit items from feed url involving redirects test.
I've looked for the test, and saw a comment stating this doesn't work for me, as the feed doesn't redirect even in a browser, is the test still correct ?

[TobiTenno]

@filipedeschamps, it seems that Travis is failing should emit items from feed url involving redirects test.
I've looked for the test, and saw a comment stating this doesn't work for me, as the feed doesn't redirect even in a browser, is the test still correct ?

It's not a failure, or shouldn't be. I've had that test turned off for a while

[TobiTenno]

@0xWryth could you allow coveralls (https://coveralls.io) access to your git repo so it can submit/publish results correctly? it looks like this is something i'll need to bug @filipedeschamps to disable as required for future runs

[0xWryth]

@TobiTenno I never used coveralls before. I signed up and turn it on for my git repo. Did I need to do anything else ?

[TobiTenno]

@TobiTenno I never used coveralls before. I signed up and turn it on for my git repo. Did I need to do anything else ?

Nope, I'll go in and retrigger the build and hope coveralls pushes properly

[0xWryth]

@TobiTenno I never used coveralls before. I signed up and turn it on for my git repo. Did I need to do anything else ?

Nope, I'll go in and retrigger the build and hope coveralls pushes properly

It seems it failed again, did i miss something ?

[TobiTenno]

@TobiTenno I never used coveralls before. I signed up and turn it on for my git repo. Did I need to do anything else ?

Nope, I'll go in and retrigger the build and hope coveralls pushes properly

It seems it failed again, did i miss something ?

I'm still lookin at it, sorry. coveralls doesn't seem to be saying why it's failing, it just is....

Oh, i see what happened. Could you possibly push an empty commit so it triggers a fully new build?

[0xWryth]

@TobiTenno I never used coveralls before. I signed up and turn it on for my git repo. Did I need to do anything else ?

Nope, I'll go in and retrigger the build and hope coveralls pushes properly

It seems it failed again, did i miss something ?

I'm still lookin at it, sorry. coveralls doesn't seem to be saying why it's failing, it just is....

Oh, i see what happened. Could you possibly push an empty commit so it triggers a fully new build?

No problem ! I just pushed an empty commit

[TobiTenno]

urgh, looks like still blocked cause not getting that coverage/coveralls status back.

@filipedeschamps could you please remove that check (and update some parts of the repo for the other PR I submitted so we can do maintenance?)

[0xWryth]

@TobiTenno any updates ?

[TobiTenno]

looks like it finally went.

[TobiTenno]

If you have any desire to try your hand on it, i started a branch to fix some other problems, but I can't merge my own changes, so feel free to pick up this if you'd like.

[filipedeschamps]

🎉 This PR is included in version 3.2.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀