-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firebase deploy hosting not running predeploy scripts #1113
Comments
Can you provide your |
Absolutely, I don't think there is anything fancy going on. Actually I just double checked, the
|
What does your output look like when you deploy? Do you see Could it perhaps be an issue with not having the correct global modules installed? Wonder if you'd have more success by prepending |
@mbleigh Yes I do see I tried using npx, but I am getting the same outcome. My output looks like this...
|
Does running the command do what you expect outside of running it as part of a deploy? What if you added something like |
Yes it works outside of deploy, that's how I was able to get it to work. Also it works with firebase-tools 6.2.0. That's a good idea: looks like it's not executing the echo.
Also I tried running 3 simple commands. Looks like that's working...
I tried deleting the |
It seems like it's silently failing the commands...but perhaps returning a success exit code? I'm at a bit of a loss as to what to ask you to try next, because I haven't been able to replicate this behavior. Are there any flags you can add to the sass/webpack commands to make them more verbose? If you do |
Hey @nickgzzjr. We need more information to resolve this issue but there hasn't been an update in 7 days. I'm marking the issue as stale and if there are no new updates in the next 3 days I will close it automatically. If you have more information that will help us get to the bottom of this, just add a comment! |
Since there haven't been any recent updates here, I am going to close this issue. @nickgzzjr if you're still experiencing this problem and want to continue the discussion just leave a comment here and we are happy to re-open this. |
I'm seeing a similar issues since updating to version 6.3.0
I've added a console log to see the translated command, which seems to be fine, but it doesn't actually attempt to execute the echo (or anything I try). I have a feeling it's something to do with some characters like '$' in my case or ':' in @nickgzzjr case. It's not my exact issue, but I'm finding similar bug reports on the cross-env library that firebase tools is using kentcdodds/cross-env#192 |
Actually, it works for me on v6.2.2 but since v6.3.0 it hasn't executed properly. My previous example probably isn't the best, my real example is:
where my
which uses process.env.FIREBASE_PROJECT within the typescript program. |
Ah, there was a change from |
Found the PR: #1068 @AbeHaskins oops, but you caught us 😅 |
Also, @AbeHaskins the change caused one of our very important predeploy scripts that we use to setup configurations in CI to silently not execute. It was very lucky that we caught it in our local environment, perhaps it's worthy of a warning or throwing an error in the next tools release if possible. |
Worked around it by moving the variable assigning into the npm script, which isn't ideal but will do for now. |
Anyone still having the original issue I was having, a good work around is to use npm scripts. |
Exactly the same problem, predeploy isn't executed automatically anymore. We have to execute it explicitly in the CI's, at least it was my case with GitLab CI. |
I was using npm scripts to do my predeploy but my npm command was silently failing when setting envs before the command. After removing my variables set before the command ( I was using |
I upgrade to firebase-tools 6.3.0 and when I deploy to hosting, it is not running my predeploy scripts. In specific I am running
sass
andwebpack
. I downgraded to 6.2.0 and everything works fine.Environment info
firebase-tools: 6.3.0
Platform: macOS
Test case
Steps to reproduce
Run
firebase deploy --only hosting
Expected behavior
"predeploy" scripts should run.
Actual behavior
"predeploy" scripts are not running.
The text was updated successfully, but these errors were encountered: