Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Error in int_ad_reporting__url_report.sql #80

Closed
1 of 4 tasks
bruceconklin opened this issue Feb 8, 2023 · 4 comments
Closed
1 of 4 tasks

[Bug] Error in int_ad_reporting__url_report.sql #80

bruceconklin opened this issue Feb 8, 2023 · 4 comments
Assignees
Labels
priority:p3 Affects many users; can wait status:in_review Currently in review type:bug Something is broken or incorrect update_type:models Primary focus requires model updates

Comments

@bruceconklin
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Describe the issue

In this intermediate model: https://github.com/fivetran/dbt_ad_reporting/blob/v1.2.0/models/intermediate/int_ad_reporting__url_report.sql

Snapchat_ads contains a series of field mappings that are set to null. This is preventing these fields from populating in the model output.
`snapchat_ads as (

{{ get_query(
    platform='snapchat_ads', 
    report_type='url', 
    field_mapping={
            'account_id': 'ad_account_id',
            'account_name': 'ad_account_name',
            'campaign_id': 'null',
            'campaign_name': 'null',
            'ad_group_id': 'null',
            'ad_group_name': 'null',
            'clicks':'swipes'
        },
    relation=ref('snapchat_ads__url_report')
) }}

), `

I believe this is an error as other mappings do not contain null values.

Relevant error log or model output

No response

Expected behavior

I expect these to map to the correct field in the source table

dbt Project configurations

N/A

Package versions

N/A

What database are you using dbt with?

other (mention it in "Additional Context")

dbt Version

N/A

Additional Context

No response

Are you willing to open a PR to help address this issue?

  • Yes.
  • Yes, but I will need assistance and will schedule time during our office hours for guidance
  • No.
@bruceconklin bruceconklin added the bug Something isn't working label Feb 8, 2023
@dumkydewilde
Copy link

Thanks for filing this @bruceconklin. This also relates to these columns not being available in the snapchat_ads package. I've created a PR to add those columns there, so they can also be used in the ad_reporting package.

@fivetran-joemarkiewicz
Copy link
Contributor

Thanks for opening this @bruceconklin and for chiming in @dumkydewilde!

I chatted with @dumkydewilde in the snapchat ads PR and will move forward with reviewing and integrating these PRs. Stay tuned as we work through these.

@fivetran-joemarkiewicz
Copy link
Contributor

@bruceconklin and @dumkydewilde I just wanted to provide an update that I have reviewed and approved the two mentioned PRs! I am kicking off our internal release process. You can most likely expect these to be merged and released by early next week.

@fivetran-joemarkiewicz fivetran-joemarkiewicz added type:bug Something is broken or incorrect priority:p3 Affects many users; can wait status:in_review Currently in review update_type:models Primary focus requires model updates and removed bug Something isn't working labels Feb 15, 2023
@fivetran-joemarkiewicz
Copy link
Contributor

FYI the above mentioned PRs have been approved and merged into the latest release of the Snapchat and Ad reporting packages.

As such, I will close out this issue. Please feel free to reopen if the issue still persists on your end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p3 Affects many users; can wait status:in_review Currently in review type:bug Something is broken or incorrect update_type:models Primary focus requires model updates
Projects
None yet
Development

No branches or pull requests

3 participants