Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeouts to wait in shutting down in tests #1404

Closed
tagomoris opened this issue Jan 6, 2017 · 0 comments · Fixed by #1426
Closed

Add timeouts to wait in shutting down in tests #1404

tagomoris opened this issue Jan 6, 2017 · 0 comments · Fixed by #1426
Labels
enhancement Feature request or improve operations v0.14

Comments

@tagomoris
Copy link
Member

Fluent::PluginHelper::Thread#thread_wait_until_stop waits until all threads exit.
Test drivers call this method.

But if there are some reason or bug not to quit threads in plugins, test runner blocks forever.
It (and Ctrl-c also) doesn't show test case names which causes blocking.
So, it's better to raise error for timeout in tests.

@tagomoris tagomoris added enhancement Feature request or improve operations v0.14 labels Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request or improve operations v0.14
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant