Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Helm Operator will try to apply multiple times when two of more releases have the same name #2101

Closed
ghost opened this issue May 28, 2019 · 0 comments · Fixed by #2123
Closed

Comments

@ghost
Copy link

ghost commented May 28, 2019

Describe the bug
If someone accidentally uses a helm release name twice. The helm operator will keep trying to apply the change back and forth between the two releases. This results in many releases and could take down someones app.

To Reproduce
Steps to reproduce the behaviour:

  1. Create two different helm releases with different settings apart from the ReleaseName

Expected behavior
The operator should back off and fail when there are two of the same release names in the queue.

** Additional info
This happend on our test clusters where we don't require PRs. A PR would likely of avoided this as someone would of checked it, but I think the helm operator should have some logic to fail when this happens. I will attempt to fix this with a PR and just wanted to log this in case someone else is already working on the issue.

Additional context
Add any other context about the problem here, e.g

  • Flux version: 1.12.2
  • Helm Operator version: 0.9.1
@ghost ghost added blocked-needs-validation Issue is waiting to be validated before we can proceed bug labels May 28, 2019
@ghost ghost changed the title Helm Operator will try to apply multiple times if github containers two of the helm helm release Helm Operator will try to apply multiple times when two of more releases have the same name May 28, 2019
@hiddeco hiddeco added helm and removed blocked-needs-validation Issue is waiting to be validated before we can proceed labels Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant