Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests from upstream are 6 years old #107

Closed
kikofernandez opened this issue May 21, 2021 · 2 comments
Closed

Tests from upstream are 6 years old #107

kikofernandez opened this issue May 21, 2021 · 2 comments

Comments

@kikofernandez
Copy link

Hi, when checking the testing from upstream (from test/JSON-Schema-Test-Suite/), I noticed that the tests that I think are used now are from 6 years ago, since the submodule commit has not changed.

Is this the case? Thanks.

@seriyps
Copy link
Contributor

seriyps commented May 24, 2021

Hi. It could easily be like that, yep. I guess, since JSON schema draft-04 have been released in 2013, there were no real need to update the test suites.

Now, if we get the draft-06 merged, I think it would make a lot of sense to update the test suites as well eventually.

@andreineculau
Copy link
Member

to be fixed in #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants