Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not leave empty dependencies #1000

Closed
perazz opened this issue Feb 25, 2024 · 0 comments · Fixed by #1001
Closed

do not leave empty dependencies #1000

perazz opened this issue Feb 25, 2024 · 0 comments · Fixed by #1001
Labels
specification Issue regarding fpm manifest and model

Comments

@perazz
Copy link
Contributor

perazz commented Feb 25, 2024

Motivation

fpm allocates the dependency array with additional space, that is left unused after the dependency tree is completed.

Because tree serialization creates an exact copy of the memory, the dependency toml/json may include several empty dependencies.

Specification

Always ensure that the dependency array has size(tree%deps) == tree%ndep after the dependency tree is built.
This will achieve no leftover empty dependencies with basically no performance penalty.

Prior Art

No response

Additional Information

No response

@perazz perazz added the specification Issue regarding fpm manifest and model label Feb 25, 2024
@henilp105 henilp105 linked a pull request Feb 26, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
specification Issue regarding fpm manifest and model
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant