-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding custom "timeout" option #189
Conversation
It closes: #179 |
Polite nudge @frinyvonnick :) |
Any plans to release this solution soon? |
This MR is released under: https://www.npmjs.com/package/nhti |
Hi 👋 I maintain node-html-to-image on my free time. As soon as possible, I'll take care of opened pull requests but I can't give you an estimated time. I suggest to use the package from @adasq during the mean time. It would be cool to have some automated canary version so I could merge pull requests without being in the urge of publishing a new version which takes time 💡 |
@adasq can you provide an example of usage please? |
Hey @ariv803
|
Hi @adasq 👋 I just removed some lint comments otherwise everything looks good to me, thanks 🙏 |
It has been published in 3.4.0 🚀 |
The problem:
We can't set a custom
timeout
(Passing it throughpuppeteerArgs
doesn't work as expected)Solution
A new option has been added. The
timeout
value (default30000
ms) is passed to:puppeteer-cluster
dependency (since the package has it's owntimeout
monitoring)puppeteer
itself (viapage.setDefaultTimeout()
)