Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make S3 signature expiration time configurable #11

Open
vladholubiev opened this issue Apr 25, 2019 · 2 comments
Open

Make S3 signature expiration time configurable #11

vladholubiev opened this issue Apr 25, 2019 · 2 comments

Comments

@vladholubiev
Copy link

Hey there,

right now expiration time for S3 signature is hard-coded to 5 min here https://github.com/froala/wysiwyg-editor-node-sdk/blob/master/lib/s3.js#L56

What do you think about making this option configurable? I'd like to raise this time from 5 min to 1 hour. Are you open to such changes in the SDK?

@vladholubiev
Copy link
Author

vladholubiev commented May 29, 2019

Meanwhile we've forked the s3.js file to make expiration time configurable: https://github.com/shelfio/froala-image-upload-s3-signature

@ayushnawani
Copy link

ayushnawani commented Apr 27, 2020

Hi, when this will be fixed?. We are still waiting for this configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants