Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(package): migrate to ng9 #134

Merged
merged 1 commit into from
Apr 27, 2020
Merged

feat(package): migrate to ng9 #134

merged 1 commit into from
Apr 27, 2020

Conversation

fulls1z3
Copy link
Owner

** PR Checklist
Please check if your PR fulfills the following requirements:

** PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

** What is the current behavior?

Issue Number: N/A

** What is the new behavior?

** Does this PR introduce a breaking change?

[x] Yes
[ ] No

** Other information

BREAKING CHANGE

@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #134 into master will decrease coverage by 1.41%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   97.95%   96.53%   -1.42%     
==========================================
  Files          12       12              
  Lines         244      231      -13     
  Branches       20       20              
==========================================
- Hits          239      223      -16     
- Misses          5        8       +3     
Impacted Files Coverage Δ
packages/@ngx-auth/core/src/auth.module.ts 71.42% <50.00%> (-11.19%) ⬇️
packages/@ngx-auth/auth0/src/auth0.module.ts 86.66% <100.00%> (-7.46%) ⬇️
packages/@ngx-auth/core/src/auth.guard.ts 100.00% <0.00%> (ø)
packages/@ngx-auth/core/src/auth.loader.ts 100.00% <0.00%> (ø)
packages/@ngx-auth/core/src/auth.service.ts 100.00% <0.00%> (ø)
packages/@ngx-auth/auth0/src/auth0.loader.ts 100.00% <0.00%> (ø)
packages/@ngx-auth/auth0/src/auth0.service.ts 100.00% <0.00%> (ø)
packages/@ngx-auth/core/src/auth-server.guard.ts 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bcd55f...62f446a. Read the comment docs.

@ghost
Copy link

ghost commented Apr 27, 2020

Warnings are found on analyzing the commit 62f446a.

2 warnings:

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬

@fulls1z3 fulls1z3 merged commit e37267e into master Apr 27, 2020
@fulls1z3 fulls1z3 deleted the ng9 branch April 27, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant