From edb804c6fac661e11cc6ba310e0852aa1900431f Mon Sep 17 00:00:00 2001 From: Bernhard Essl Date: Mon, 18 Aug 2014 19:59:25 +0200 Subject: [PATCH 1/4] Added missing test for the 'locale' method. --- test/Faker/Provider/MiscellaneousTest.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/Faker/Provider/MiscellaneousTest.php b/test/Faker/Provider/MiscellaneousTest.php index a3ef36fdb4..0bafb04ab4 100644 --- a/test/Faker/Provider/MiscellaneousTest.php +++ b/test/Faker/Provider/MiscellaneousTest.php @@ -27,6 +27,11 @@ public function testSha256() $this->assertRegExp('/^[a-z0-9]{64}$/', Miscellaneous::sha256()); } + public function testLocale() + { + $this->assertRegExp('/^[a-z]{2}_[A-Z]{2}$/', Miscellaneous::locale()); + } + public function testCountryCode() { $this->assertRegExp('/^[A-Z]{2}$/', Miscellaneous::countryCode()); From 0ae5d68ca2ae493f425e8b3aeda440effd4b354d Mon Sep 17 00:00:00 2001 From: Bernhard Essl Date: Mon, 18 Aug 2014 20:04:23 +0200 Subject: [PATCH 2/4] Bugfix for 'locale' test. --- test/Faker/Provider/MiscellaneousTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/Faker/Provider/MiscellaneousTest.php b/test/Faker/Provider/MiscellaneousTest.php index 0bafb04ab4..779583759f 100644 --- a/test/Faker/Provider/MiscellaneousTest.php +++ b/test/Faker/Provider/MiscellaneousTest.php @@ -29,7 +29,7 @@ public function testSha256() public function testLocale() { - $this->assertRegExp('/^[a-z]{2}_[A-Z]{2}$/', Miscellaneous::locale()); + $this->assertRegExp('/^[a-z]{2,3}_[A-Z]{2}$/', Miscellaneous::locale()); } public function testCountryCode() From 29c81a633744a3fcf042ef3b5280dde53c012846 Mon Sep 17 00:00:00 2001 From: Bernhard Essl Date: Tue, 19 Aug 2014 15:58:06 +0200 Subject: [PATCH 3/4] Added PhoneNumber for the de_AT Provider. --- src/Faker/Provider/de_AT/PhoneNumber.php | 19 ++++++++++++ test/Faker/Provider/de_AT/PhoneNumberTest.php | 29 +++++++++++++++++++ 2 files changed, 48 insertions(+) create mode 100644 src/Faker/Provider/de_AT/PhoneNumber.php create mode 100644 test/Faker/Provider/de_AT/PhoneNumberTest.php diff --git a/src/Faker/Provider/de_AT/PhoneNumber.php b/src/Faker/Provider/de_AT/PhoneNumber.php new file mode 100644 index 0000000000..9e0cfdff3d --- /dev/null +++ b/src/Faker/Provider/de_AT/PhoneNumber.php @@ -0,0 +1,19 @@ +addProvider(new PhoneNumber($faker)); + $this->faker = $faker; + } + + public function testPhoneNumberFormat() + { + $number = $this->faker->phoneNumber; + $this->assertRegExp('/^06\d{2} \d{7}|\+43 \d{4} \d{4}(-\d{2})?$/', $number); + } + +} From 92b53d4a5e8a8fa5c2a04a1216300e3b911917b7 Mon Sep 17 00:00:00 2001 From: Bernhard Essl Date: Tue, 19 Aug 2014 16:24:26 +0200 Subject: [PATCH 4/4] psr-2 fix --- test/Faker/Provider/de_AT/PhoneNumberTest.php | 1 - 1 file changed, 1 deletion(-) diff --git a/test/Faker/Provider/de_AT/PhoneNumberTest.php b/test/Faker/Provider/de_AT/PhoneNumberTest.php index 557fd4dbfd..2d61ad5ee7 100644 --- a/test/Faker/Provider/de_AT/PhoneNumberTest.php +++ b/test/Faker/Provider/de_AT/PhoneNumberTest.php @@ -25,5 +25,4 @@ public function testPhoneNumberFormat() $number = $this->faker->phoneNumber; $this->assertRegExp('/^06\d{2} \d{7}|\+43 \d{4} \d{4}(-\d{2})?$/', $number); } - }