Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move funds on end of LBP to XYK #247

Open
2 of 3 tasks
mrq1911 opened this issue Nov 17, 2021 · 6 comments
Open
2 of 3 tasks

Move funds on end of LBP to XYK #247

mrq1911 opened this issue Nov 17, 2021 · 6 comments
Assignees
Labels
IN PROGRESS In progress in Zenhub (cleanup)

Comments

@mrq1911
Copy link
Member

mrq1911 commented Nov 17, 2021

  • add ability move funds to xyk after lbp concludes
  • disallow creation of lbp if xyk already exists
  • disallow creation of xyk before lbp ends

discord thread

@Roznovjak Roznovjak self-assigned this Jan 3, 2022
@Roznovjak
Copy link
Collaborator

@lumir-mrkva Do we want to also create XYK pool at the end of LBP if the pool doesn't exist?

@Roznovjak
Copy link
Collaborator

@lumir-mrkva I have some questions.
What if XYK pool already exists before LBP? (I thing there is nothing we can do to prevent it).
Do we want to create XYK pool immediately at the end of LBP or when remove_liquidity is called? (In the former case, pool creation needs to be somehow automated/scheduled).

I have also discussed architectural design with Martin, and we like the idea of creating a new pallet for it.

@Roznovjak
Copy link
Collaborator

The second part of the task was already solved by this PR.

@mrq1911
Copy link
Member Author

mrq1911 commented Jan 10, 2022

you shouldn't be able to create LBP if the XYK pool already exists

@Roznovjak
Copy link
Collaborator

@lumir-mrkva ability to create XYK at the end of LBP and transfer funds there should be configurable in the config or in the create_pool method? In other words, configurable for all LBP pools without an exception or configurable individually for each pool?

@jak-pan
Copy link
Contributor

jak-pan commented Apr 27, 2022

@lumir-mrkva ability to create XYK at the end of LBP and transfer funds there should be configurable in the config or in the create_pool method? In other words, configurable for all LBP pools without an exception or configurable individually for each pool?

This should be decision of the team conducting the LBP. There are different use-cases that you might do with LBP including just distributing / sale of tokens instead of initializing liquidity. If I'd tackle this I would look at the close / end function and do the logic there where it can be an option if final weights are 50/50.

Optionally the close function could create only partial pool and transfer the rest to the owner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IN PROGRESS In progress in Zenhub (cleanup)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants